set vm_info to kvm for digitalocean instances

Bug #1743232 reported by Eric Desrochers
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Landscape Client
Fix Released
Undecided
Unassigned
landscape-client (Ubuntu)
Fix Released
Medium
Eric Desrochers
Trusty
Fix Released
Medium
Eric Desrochers
Xenial
Fix Released
Medium
Eric Desrochers
Artful
Fix Released
Medium
Eric Desrochers
Bionic
Fix Released
Medium
Eric Desrochers

Bug Description

[Impact]

digitalocean instance type is not a recognised VM type in Landscape and thus won't allow use of a Virtual Guest asset to register with.

The digitalocean type uses a KVM-family hypervisor (displaying "digitalocean" in sys_vendor which landscape-client doesn't recognise, thus cannot associate/map to kvm)

[Test Case]

 * Deploy a digitalocean instance
 * Look sys_vendor
   $ cat /sys/class/dmi/id/sys_vendor
   digitalocean

 * Install landscape-client
 * Register the client to the desired landscape-server
 * Verify "VM Type" to be "kvm" under the computer info (in landscape-server)

[Regression Potential]

 * No regression anticipated, the fix is only adding a new entry mapping to recognize digitalocean instances.

[Other Info]

 * Upstream commit:
   https://github.com/CanonicalLtd/landscape-client/pull/24/files

Eric Desrochers (slashd)
Changed in landscape-client (Ubuntu Trusty):
status: New → Confirmed
Changed in landscape-client (Ubuntu Xenial):
status: New → Confirmed
Changed in landscape-client (Ubuntu Zesty):
status: New → Confirmed
Changed in landscape-client (Ubuntu Artful):
status: New → Confirmed
Changed in landscape-client (Ubuntu Bionic):
status: New → Confirmed
Changed in landscape-client (Ubuntu Trusty):
importance: Undecided → Medium
Changed in landscape-client (Ubuntu Xenial):
importance: Undecided → Critical
importance: Critical → Medium
Changed in landscape-client (Ubuntu Zesty):
importance: Undecided → Medium
Changed in landscape-client (Ubuntu Artful):
importance: Undecided → Medium
Changed in landscape-client (Ubuntu Bionic):
importance: Undecided → Medium
Changed in landscape-client (Ubuntu Trusty):
assignee: nobody → Eric Desrochers (slashd)
Changed in landscape-client (Ubuntu Xenial):
assignee: nobody → Eric Desrochers (slashd)
Changed in landscape-client (Ubuntu Zesty):
assignee: nobody → Eric Desrochers (slashd)
Changed in landscape-client (Ubuntu Artful):
assignee: nobody → Eric Desrochers (slashd)
Changed in landscape-client (Ubuntu Bionic):
assignee: nobody → Eric Desrochers (slashd)
tags: added: lds-squad sts
tags: added: sts-sponsor-slashd
Changed in landscape-client (Ubuntu Bionic):
status: Confirmed → In Progress
Eric Desrochers (slashd)
description: updated
Revision history for this message
David Coronel (davecore) wrote :

I tested Eric's fix on a Digital Ocean droplet with 2 GB Memory and 40 GB Disk with Ubuntu 17.10 upgraded to Bionic with do-release-upgrade -d (because Bionic images are not available)

==============

root@ubuntu-2gb-tor1-01:~# cat /sys/class/dmi/id/sys_vendor
DigitalOcean

root@ubuntu-2gb-tor1-01:~# dpkg -l | grep -i landscape-client
ii landscape-client 16.03-0ubuntu5 amd64 The Landscape administration system client

root@ubuntu-2gb-tor1-01:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu Bionic Beaver (development branch)
Release: 18.04
Codename: bionic

Computer information in Landscape:
-Distribution: Ubuntu Bionic Beaver (development branch) (bionic)
-VM Type: kvm
-Product identifier: Droplet

Changed in landscape-client:
status: New → Fix Committed
status: Fix Committed → In Progress
Eric Desrochers (slashd)
Changed in landscape-client (Ubuntu Bionic):
status: In Progress → Fix Committed
Revision history for this message
Eric Desrochers (slashd) wrote :

I'll sponsor Simon's debdiff found in LP: #1742531 as soon as landscape-client is consider valid for bionic.

For now it is stuck in bionic-proposed, waiting for the non-i386/amd64 builds to be back operational.

# Ubuntu excuses page
landscape-client (16.03-0ubuntu4 to 16.03-0ubuntu5)
Maintainer: Ubuntu Developers
0 days old
missing build on arm64: landscape-client, landscape-common (from 16.03-0ubuntu4)
missing build on armhf: landscape-client, landscape-common (from 16.03-0ubuntu4)
missing build on ppc64el: landscape-client, landscape-common (from 16.03-0ubuntu4)
missing build on s390x: landscape-client, landscape-common (from 16.03-0ubuntu4)
Not considered

- Eric

Changed in landscape-client:
milestone: none → 18.01
Changed in landscape-client:
status: In Progress → Fix Committed
Eric Desrochers (slashd)
no longer affects: landscape-client (Ubuntu Zesty)
Eric Desrochers (slashd)
Changed in landscape-client (Ubuntu Trusty):
status: Confirmed → In Progress
Changed in landscape-client (Ubuntu Xenial):
status: Confirmed → In Progress
Changed in landscape-client (Ubuntu Artful):
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package landscape-client - 16.03-0ubuntu5

---------------
landscape-client (16.03-0ubuntu5) bionic; urgency=medium

  * d/p/set-vm-info-to-kvm-for-aws-C5-instances.patch:
    Sets vm_info to kvm for new AWS EC2 C5 instances. (LP: #1742531)

  * d/p/set-vm-info-to-kvm-for-digitalocean-instances.patch:
    Sets vm_info to kvm for digitalocean instances. (LP: #1743232)

 -- Eric Desrochers <email address hidden> Sun, 14 Jan 2018 11:05:38 -0500

Changed in landscape-client (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Eric Desrochers (slashd) wrote :

lds-client has been uploaded for TXA. It is now waiting on SRU verification team to approve the uploads.

- Eric

Eric Desrochers (slashd)
tags: added: sts-sponsor-slashd-done
removed: sts-sponsor-slashd
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Eric, or anyone else affected,

Accepted landscape-client into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/landscape-client/16.03-0ubuntu3.17.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in landscape-client (Ubuntu Artful):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-artful
Changed in landscape-client (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed-xenial
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Eric, or anyone else affected,

Accepted landscape-client into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/landscape-client/16.03-0ubuntu2.16.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Eric, or anyone else affected,

Accepted landscape-client into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/landscape-client/14.12-0ubuntu6.14.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in landscape-client (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed-trusty
Revision history for this message
David Coronel (davecore) wrote :

I tested that the new landscape-client package installs on Digital Ocean droplets with trusty, xenial and artful and registers in Landscape with the right information. Attaching screenshots.

Revision history for this message
David Coronel (davecore) wrote :
Revision history for this message
David Coronel (davecore) wrote :
Revision history for this message
David Coronel (davecore) wrote :
Eric Desrochers (slashd)
tags: added: verification-done verification-done-artful verification-done-trusty verification-done-xenial
removed: verification-needed verification-needed-artful verification-needed-trusty verification-needed-xenial
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for landscape-client has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package landscape-client - 16.03-0ubuntu2.16.04.3

---------------
landscape-client (16.03-0ubuntu2.16.04.3) xenial; urgency=medium

  * d/p/set-vm-info-to-kvm-for-aws-C5-instances.patch:
    Sets vm_info to kvm for new AWS EC2 C5 instances. (LP: #1742531)

  * d/p/set-vm-info-to-kvm-for-digitalocean-instances.patch:
    Sets vm_info to kvm for digitalocean instances. (LP: #1743232)

 -- Eric Desrochers <email address hidden> Tue, 23 Jan 2018 10:53:42 -0500

Changed in landscape-client (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package landscape-client - 14.12-0ubuntu6.14.04.2

---------------
landscape-client (14.12-0ubuntu6.14.04.2) trusty; urgency=medium

  * d/p/set-vm-info-to-kvm-for-aws-C5-instances.patch:
    Sets vm_info to kvm for new AWS EC2 C5 instances. (LP: #1742531)

  * d/p/set-vm-info-to-kvm-for-digitalocean-instances.patch:
    Sets vm_info to kvm for digitalocean instances. (LP: #1743232)

 -- Eric Desrochers <email address hidden> Tue, 23 Jan 2018 11:32:00 -0500

Changed in landscape-client (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package landscape-client - 16.03-0ubuntu3.17.10.2

---------------
landscape-client (16.03-0ubuntu3.17.10.2) artful; urgency=medium

  * d/p/set-vm-info-to-kvm-for-aws-C5-instances.patch:
    Sets vm_info to kvm for new AWS EC2 C5 instances. (LP: #1742531)

  * d/p/set-vm-info-to-kvm-for-digitalocean-instances.patch:
    Sets vm_info to kvm for digitalocean instances. (LP: #1743232)

 -- Eric Desrochers <email address hidden> Tue, 23 Jan 2018 10:44:56 -0500

Changed in landscape-client (Ubuntu Artful):
status: Fix Committed → Fix Released
Changed in landscape-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.