Simple Scan not sending mail

[Maxim]

[Impact]
Simple scan is unable to send email with PDF attachments.

[Test Case]
1. Open Simple Scan
2. Scan a document in text mode (the default)
3. Email the document

Expected result:
Email client opens with attached .pdf file

Observed result:
Nothing occurs. Running 'simple-scan -d' from the command line shows an error about trying to run the invalid command 'xdg-email--attach'.

[Regression Potential]
Low. Adds back in a missing space character that got dropped in some refactoring.

Original description:

This is my first bug report so I hope I'm making sense:

Simple scan doesn't send mail when trying to send a scanned document. Using simple-scan -d I get this error:

[+9.63s] WARNING: app-window.vala:1208: Unable to email document: Failed to execute child process “xdg-email--attach” (No such file or directory)

Looking through the code within app-window.vala on lines 1194 - 1196 I see:

            var command_line = "xdg-email";
            if (type == "pdf")
                command_line += "--attach %s".printf (file.get_path ());

I'm thinking there should be a space " " prior to --attach on line 1196.

[tod (todipame)]

Same error
WARNING: app-window.vala:1208: Unable to email document: L’exécution du processus fils « xdg-email--attach » a échoué (Aucun fichier ou dossier de ce type)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Robert Ancell (robert-ancell)]

commit 6990573196505dbf3e3e79c5e409a971ae8078b8
Author: Robert Ancell <email address hidden>
Date: Mon Jan 22 15:15:50 2018 +1300

    Fix email sending failing with PDF attachments

[Robert Ancell (robert-ancell)]

Thanks for finding!

[Launchpad Janitor (janitor)]

This bug was fixed in the package simple-scan - 3.26.3-0ubuntu1

---------------
simple-scan (3.26.3-0ubuntu1) bionic; urgency=medium

  * New upstream stable release:
    - Fix email sending failing with PDF attachments (LP: #1743096)

 -- Robert Ancell <email address hidden> Mon, 22 Jan 2018 15:42:39 +1300

[Łukasz Zemczak (sil2100)]

Hello Maxim, or anyone else affected,

Accepted simple-scan into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/simple-scan/3.26.3-0ubuntu0.17.10.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Maxim (maxim-switz)]

I can confirm that version 3.26.3-0ubuntu1 has fixed the problem I reported.

Thanks very much!!

[Launchpad Janitor (janitor)]

This bug was fixed in the package simple-scan - 3.26.3-0ubuntu0.17.10.0

---------------
simple-scan (3.26.3-0ubuntu0.17.10.0) artful; urgency=medium

  * New upstream stable release:
    - Fix email sending failing with PDF attachments (LP: #1743096)

 -- Robert Ancell <email address hidden> Mon, 22 Jan 2018 15:37:36 +1300

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for simple-scan has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.