Needing to run "openstack overcloud container image prepare" twice is confusing and complicated

[Steve Baker]

When the user is using the undercloud registry, they need to run prepare once to generate the upload instructions file, and again with a different --namespace to generate the enironment file.

This could be simplified into a single call by using the --push-destination as the namespace when building the image env parameter values.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/528616

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/528621

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/528627

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/528616
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=bf8e6bea0f1e8b3ea5adf0e94bf02a8939b44dbf
Submitter: Zuul
Branch: master

commit bf8e6bea0f1e8b3ea5adf0e94bf02a8939b44dbf
Author: Steve Baker <email address hidden>
Date: Mon Dec 18 17:05:19 2017 +1300

    Use push_destination as the registry host in env file

    When using the undercloud registry, the prepare call needs to be run
    twice, once to generate the upload instructions file, and again with a
    different --namespace to generate the environment file.

    This can be combined into a single call by modifying the env
    paramaters by replacing the host portion of the registry path to use
    push_destination. That is what this change does.

    Change-Id: I7ad0ae8dee665c8c7d0599eb6d29787bf9043762
    Closes-Bug: #1738663

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/528627
Committed: https://git.openstack.org/cgit/openstack/tripleo-docs/commit/?id=f5853e342500a6d4922758c6f793b6ef6021adc0
Submitter: Zuul
Branch: master

commit f5853e342500a6d4922758c6f793b6ef6021adc0
Author: Steve Baker <email address hidden>
Date: Mon Dec 18 17:54:39 2017 +1300

    Call "openstack overcloud container image" only once

    Thanks to the fix for bug #1738663 it is no longer necessary to run
    prepare separately to generate the environment file and the images
    file.

    Change-Id: Ice0fcb4e6b8f5f18694d989f5152cb23a3d88569
    Related-Bug: #1738663

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.4.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/528621
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=445157148a46452c26ffa070e31b4da1c8e4503d
Submitter: Zuul
Branch: master

commit 445157148a46452c26ffa070e31b4da1c8e4503d
Author: Steve Baker <email address hidden>
Date: Mon Dec 18 17:28:57 2017 +1300

    Run "overcloud container image prepare" only once

    Thanks to the fix for bug #1738663 it is no longer necessary to run
    prepare separately to generate the environment file and the images
    file. The second run only occurs now for ocata, pike runs.

    Change-Id: I54a08d696ba7f67caa114a2beffe5de601eb1a92
    Related-Bug: #1738663