iscsitarget 1.4.20.3+svn502-2ubuntu4.4 ADT test failure with linux 4.4.0-102.125

[Stefan Bader]

[SRU Justification]

Impact: No impact on the binary packages. This is solely fixing the dep8 test.

Fix: Update on the dep8 daemon test to start the daemon correctly and check for the right name.

Testcase: ADT testing getting reliable.

Risk of regression: none

---

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/i/iscsitarget/20171122_151040_15576@/log.gz
    i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/i386/i/iscsitarget/20171122_154506_15576@/log.gz
    ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/ppc64el/i/iscsitarget/20171122_145441_15576@/log.gz
    s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/i/iscsitarget/20171122_145247_15576@/log.gz

[Stefan Bader (smb)]

This is actually a broken test case for the daemon. First it is actually named ietd (not iscsitarget) and second it is already in (attempted) started state after installation, so it needs a restart call to be started after changing the config file. My guess is that the test only ever passed because the test for the daemon running was done quickly enough to catch the sysvinit script in ps output.

[Łukasz Zemczak (sil2100)]

Hello Stefan, or anyone else affected,

Accepted iscsitarget into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/iscsitarget/1.4.20.3+svn502-2ubuntu4.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Stefan Bader (smb)]

Since the change is purely in the dep8 test, ADT testing is the validation:

https://autopkgtest.ubuntu.com/packages/iscsitarget/xenial/amd64 / https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/i/iscsitarget/20180213_134807_5945d@/log.gz

[Łukasz Zemczak (sil2100)]

Hello Stefan, or anyone else affected,

Accepted iscsitarget into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/iscsitarget/1.4.20.3+svn499-0ubuntu2.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Launchpad Janitor (janitor)]

This bug was fixed in the package iscsitarget - 1.4.20.3+svn502-2ubuntu4.5

---------------
iscsitarget (1.4.20.3+svn502-2ubuntu4.5) xenial; urgency=medium

  * Fix daemon dep8 test so it really tests for the running
    daemon (LP: #1734855).

 -- Stefan Bader <email address hidden> Thu, 01 Feb 2018 10:18:55 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for iscsitarget has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Mathew Hodson (mhodson)]

I verified the ADT testing for the Trusty package same as was done for Xenial.

https://autopkgtest.ubuntu.com/packages/iscsitarget/trusty/amd64

1.4.20.3+svn499-0ubuntu2.5
iscsitarget/1.4.20.3+svn499-0ubuntu2.5
2018-02-15 13:36:58 UTC
0h 04m 26s
-
pass

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-trusty/trusty/amd64/i/iscsitarget/20180215_133658_edbe8@/log.gz

autopkgtest [13:36:45]: test daemon: [-----------------------
Enable daemon ... PASS
Start daemon ... PASS
autopkgtest [13:36:48]: test daemon: -----------------------]
autopkgtest [13:36:49]: test daemon: - - - - - - - - - - results - - - - - - - - - -
daemon PASS

[Robie Basak (racb)]

This doesn't seem to fix the armhf dep8 failure for iscsitarget though? The failure looks related to this bug.

[Andy Whitcroft (apw)]

Hello Stefan, or anyone else affected,

Accepted iscsitarget into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/iscsitarget/1.4.20.3+svn499-0ubuntu2.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Stefan Bader (smb)]

This is just a fixup for ADT, verification should be done that way.

[Launchpad Janitor (janitor)]

This bug was fixed in the package iscsitarget - 1.4.20.3+svn499-0ubuntu2.6

---------------
iscsitarget (1.4.20.3+svn499-0ubuntu2.6) trusty; urgency=medium

  * Fix ADT requirements to run daemon test only when isolation
    level machine is available.

iscsitarget (1.4.20.3+svn499-0ubuntu2.5) trusty; urgency=medium

  * Fix daemon dep8 test so it really tests for the running
    daemon (LP: #1734855).

iscsitarget (1.4.20.3+svn499-0ubuntu2.4) trusty; urgency=medium

  * Remove compat code for 4.4.0-84 and detect sock_recvmsg signature
    during build. (LP: #1732746)

 -- Stefan Bader <email address hidden> Mon, 28 Jan 2019 11:16:06 +0100