Need to consolidate country code information for Mahara 18.04.0
Bug #1732046 reported by
Robert Lyon
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Currently we have lib/country.php containing the 'Country' class which list the 2 and 3 char codes
And we have getoptions_
We don't need both - we should make the Country class the preferred one and fetch our 2 char codes for getoptions_
Changed in mahara: | |
status: | New → In Progress |
importance: | Undecided → Medium |
milestone: | none → 18.04.0 |
summary: |
- Need to consolidate country code information + Need to consolidate country code information for Mahara 18.04.0 |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /reviews. mahara. org/8277 /git.mahara. org/mahara/ mahara/ commit/ 3b64fa1f862b9fd f3b6a72c8d7a032 0d6202ac81
Committed: https:/
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master
commit 3b64fa1f862b9fd f3b6a72c8d7a032 0d6202ac81
Author: Robert Lyon <email address hidden>
Date: Tue Nov 14 11:48:00 2017 +1300
Bug 1732046: Fixing up the country codes within country lib file
Fixing some mistakes from Bug 1514647 where we forgot to update the
Country class, which is used as part of the import/export leap2A process
Also adjusting getoptions_ country( ) so that it fetches the 2 char
codes from the Country class rather than repeating code.
behatnotneeded
Change-Id: I901e6a1827da31 fbdbb1ac4c9fb8e 46b247b5dc2
Signed-off-by: Robert Lyon <email address hidden>