Remove unused code from lib/view.php that was never used correctly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Rebecca Blundell |
Bug Description
I noticed a bug in the theme/raw/
So I wondered why this didn't cause a problem rendering the page and found the code would only be rendered if $configure was true.
And that would only happen if a block instance called render_editing with $configure = true
And I noticed on view/blocks.php that happens when
$blockid = $view->
But $view->
Changing the number from 0 to a valid block number on an edit screen and then reloading page gives all manner of errors.
Looking at the commit that added the set/get functions 09c73752c11c800
We should clean up this area and remove any/all code that is not actually being used
Changed in mahara: | |
milestone: | none → 18.04.0 |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in mahara: | |
assignee: | nobody → Rebecca Blundell (rjb-dev) |
Changed in mahara: | |
status: | Confirmed → In Progress |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "master" branch: https:/ /reviews. mahara. org/8354