The filter on 'My friends' page is broken

[Robert Lyon]

The javascript used to handle the filter is not correct. It does not fetch the current value from select dropdown

[Robert Lyon (robertl-9)]

To Test:

Have a user that has made some friends and have some pending friendships (where other users are trying to befriend that user)

On the Group -> My friends page you should be able to filter by friends / pending.

Before patch: no change when using filter
After patch: should be able to display pending only and/or current only

[Robert Lyon (robertl-9)]

https://reviews.mahara.org/#/c/8194/

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8194
Committed: https://git.mahara.org/mahara/mahara/commit/3e69f9e1953a280d12a01fea3f47c8614333fb64
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3e69f9e1953a280d12a01fea3f47c8614333fb64
Author: Robert Lyon <email address hidden>
Date: Fri Oct 27 22:20:53 2017 +1300

Bug 1727991: Fixing the filter on 'My friends' page

Was broken jquery syntax

behatnotneeded

Change-Id: I7d6d4a069a56c76197cf61c3397b8657f07d852d
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8196

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8196
Committed: https://git.mahara.org/mahara/mahara/commit/b43d46934814ece6c68f2c83f4dac6710deb913c
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit b43d46934814ece6c68f2c83f4dac6710deb913c
Author: Robert Lyon <email address hidden>
Date: Fri Oct 27 22:20:53 2017 +1300

Bug 1727991: Fixing the filter on 'My friends' page

Was broken jquery syntax

behatnotneeded

Change-Id: I7d6d4a069a56c76197cf61c3397b8657f07d852d
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 3e69f9e1953a280d12a01fea3f47c8614333fb64)