Cherry-pick upstream warning fix and compatibility with other extensions

Bug #1727242 reported by Didier Roche-Tolomelli
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-shell-extension-ubuntu-dock (Ubuntu)
Fix Released
Low
Didier Roche-Tolomelli
Artful
Fix Released
Low
Unassigned

Bug Description

[ Impact ]

Cherry-pick upstream fixes to remove warnings and make the Dock compatible with other extension exposing the main object.

The main object was hidden now with latest mozjs, reexpose it declaring it as var

[ Test Case ]

* Install latest Ubuntu Dock from proposed
* Log out/in back

[ Regression Potential ]

* The code is functionally equivalent, already in dash to dock upstream, and exposing the object is a let/var change, without any impact.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
assignee: nobody → Didier Roche (didrocks)
status: New → Triaged
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
importance: Undecided → Low
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Didier, or anyone else affected,

Accepted gnome-shell-extension-ubuntu-dock into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/0.7.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Artful):
status: New → Fix Committed
tags: added: verification-needed verification-needed-artful
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Tried with this version, no regression to report, +1

tags: added: verification-done verification-done-artful
removed: verification-needed verification-needed-artful
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: Triaged → Fix Committed
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Artful):
importance: Undecided → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 0.7.1

---------------
gnome-shell-extension-ubuntu-dock (0.7.1) artful; urgency=medium

  * Fix Ubuntu dock won't start after Dash to dock uninstalled (LP: #1726935)
  * Cherry-pick couple of upstream Dash to Dock fixes: (LP: #1727242)
    - warning fix with latest mozjs.
    - expose the dash to dock main object for other extensions to pick it up.

 -- Didier Roche <email address hidden> Wed, 25 Oct 2017 10:51:28 +0200

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: Fix Committed → Fix Released
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Artful):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for gnome-shell-extension-ubuntu-dock has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.