[atanks] no .desktop file

Bug #172588 reported by Sebastian Rode
6
Affects Status Importance Assigned to Milestone
atanks (Debian)
Fix Released
Unknown
atanks (Ubuntu)
Fix Released
Low
Emmet Hikory

Bug Description

Binary package hint: atanks

There is no atanks entry in the menu.

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

Confirmed on Hardy.

Changed in atanks:
status: New → Confirmed
Changed in atanks:
status: Unknown → New
Revision history for this message
Salvatore Palma (palma-salvatore) wrote :

I'm working for this

Changed in atanks:
assignee: nobody → palma-salvatore
Revision history for this message
Salvatore Palma (palma-salvatore) wrote :

This is the bugfix

Changed in atanks:
assignee: palma-salvatore → dktrkranz
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Consider adjusting your .desktop file by using atank-icon as Icon field, there is no need to move it from its position (/usr/share/pixmaps/atanks-icon.xpm, actually).

Changed in atanks:
assignee: dktrkranz → palma-salvatore
importance: Undecided → Low
status: Confirmed → In Progress
Revision history for this message
Salvatore Palma (palma-salvatore) wrote :

This is the correct bugfix

Revision history for this message
Salvatore Palma (palma-salvatore) wrote :
Changed in atanks:
assignee: palma-salvatore → dktrkranz
Changed in atanks:
assignee: dktrkranz → nobody
status: In Progress → Confirmed
Changed in atanks:
assignee: nobody → palma-salvatore
status: Confirmed → In Progress
assignee: palma-salvatore → nobody
Changed in atanks:
assignee: nobody → palma-salvatore
Revision history for this message
Siegfried Gevatter (rainct) wrote :

Just a little note: If you have package «ubuntu-dev-tools» installed, executing «update-maintainer» on the source directory will automatically change the Maintainer field, if needed. You don't have to use it, of course, but I tell you for the case you're interested ;).

Changed in atanks:
assignee: palma-salvatore → nobody
Revision history for this message
Emmet Hikory (persia) wrote :

Thanks for the patch. I've unsubscribed ubuntu-universe-sponsors as this still needs a little work. Firstly, it appears that the icon installation is being removed from debian/rules, which doesn't seem ideal when combined with a ,desktop installation. Secondly, this package uses dh_install, so it's probably better to add the .desktop file to debian/atanks.install (as there's no need to change the name during the installation). Please resubscribe the sponsors queue when these issues have been addressed.

Changed in atanks:
assignee: nobody → palma-salvatore
Changed in atanks:
assignee: palma-salvatore → nobody
Changed in atanks:
assignee: nobody → palma-salvatore
Revision history for this message
Salvatore Palma (palma-salvatore) wrote :

This is the debdiff correct :)

Emmet Hikory (persia)
Changed in atanks:
assignee: palma-salvatore → nobody
status: In Progress → Confirmed
Emmet Hikory (persia)
Changed in atanks:
assignee: nobody → persia
status: Confirmed → In Progress
Revision history for this message
Emmet Hikory (persia) wrote :

Uploaded. Thanks.

Changed in atanks:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package atanks - 2.6-1ubuntu1

---------------
atanks (2.6-1ubuntu1) hardy; urgency=low

  * Provided a .desktop file (LP: #172588)
  * debian/atanks.install:
    - install .desktop file
  * debian/control:
    - updated Maintainer field
  * debian/rules:
    - added dh_destkop

 -- Salvatore Palma <email address hidden> Tue, 18 Dec 2007 15:25:03 +0100

Changed in atanks:
status: Fix Committed → Fix Released
Changed in atanks:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.