Web Client: Copy Buckets missing TCN column

[Terran McCanna]

In 3.0.0 - the Copy Buckets view is missing TCN as a column option (on both the Pending Copies tab and the Bucket View tab)

[Robert J Jackson (rjackson-deactivatedaccount)]

Due Date is also missing as a column selection.

[Robert J Jackson (rjackson-deactivatedaccount)]

When comparing to the legacy staff client there are several fields missing from the column options. Also, it appears that the title is shown in lower case making label printing with title not what is desired.

[Robert J Jackson (rjackson-deactivatedaccount)]

Received request to have Author on Column picker from library staff - I know previous comment indicated several columns missing but wanted to ensure Author was included in that list!

[Pamela Smith (pamela-smith)]

Another field we need in the copy bucket column picker is checkout date, it's available in the staff client.

[Tiffany Little (tslittle)]

While working on this, I wrote down all the available columns in XUL. There are a couple that I wonder what they are--I've never used them. Does anyone have any input on these?

Document ID
Owned By (as opposed to Owning Library)
Service
Message (as opposed to Alert Message)

[Andrea Neiman (aneiman)]

IIRC, Document ID = Bib ID (or at least it did in my old system) but it's been a while since I've looked at XUL.

[Tiffany Little (tslittle)]

I think you're right, Andrea. I won't include that one since Record ID is already present. Thanks!

[Tiffany Little (tslittle)]

I have a patch here that returns many of the columns that were in XUL. It also puts the options in alphabetical order.

Columns that are not in this patch:
Alert Message
Circulation ID
Edition
Fine Level
Fines Stopped
Fines Stopped Time
Holds Count
Message
Owned By
Part
Remaining Renewals
Route To
Service

ttp://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=855a295c177bf6030f2c55bd0ac5fee24ce00bb9

Feedback definitely appreciated if anyone sees anything off or I've done anything incorrectly.

[Remington Steed (rjs7)]

Nice work Tiffany! Overall it looks good to me. Just one question: Could you explain why you removed the auto-fields setting?

[Tiffany Little (tslittle)]

(Caveat: Please tell me if I've misunderstood anything.)

When the columns were auto-generated, they wouldn't come in in alphabetical order and there would also be fields that would have two instances because it was in the auto-populated columns + specifically called out in the tt2. I think Copy ID was one of these. For things like Creating User, Editing User, etc., in the auto-populated columns it would get pulled in as the user's DB ID, whereas it seemed more user-friendly to have the user's username/barcode so I wanted to modify what was displayed. And I assumed that if I specifically called it out, that it would then have two instances in the list, the same as Copy ID.

I also wanted to modify things like Loan Duration and Fine Level which display as an integer to show as text, but I couldn't ever really grasp how to get the 'string_pick' that's operating in Item Status to work here.

So short answer is, to alphabetize + I didn't want fields to show twice if I was trying to modify what displayed.

[Remington Steed (rjs7)]

That makes sense to me. Thanks for explaining.

[Derek C. Zoladz (derekz)]

While the TCN (value and label) have been added to the 'Bucket View' tab, the current patch only addresses the 'Bucket View' tab of the item buckets interface.

I'm very much in favor of a sorted list of options in the column picker, but I would like to recommend that the options in the column picker are equivalent on both the 'Pending Items' tab and the 'Bucket View' tab of the item buckets interface.

[Tiffany Little (tslittle)]

Thanks Derek! Removing the pullrequest tag to keep working on it.

[Tiffany Little (tslittle)]

Scrapped almost wholesale what I had before, since there's been a subsequent fix for the duplicating columns issue with having an autofield and a defined field show the same thing.

New branch is here for review:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=9ba5d198fa9f4390dcd651e63d6bffea4450b856

It adds in classification, ISBN, owning library, pub date, publisher, TCN and TCN source.

There are several other bugs that deal with columns in copy buckets, so I just wanted to take these for right now since the original bug report dealt with TCN.

Oh, and it also adds all the columns in the Pending tab as well.

[Elaine Hardy (ehardy)]

Testing https://tiffany-master.gapines.org/eg/staff/

In Bucket view:

Columns in 3.4.1 but not in test:

Owning Library
Pub date
Publisher
TCN
TCN value
ISBN

Columns added to test:
Alert msg: doesn’t display
Call number/volume: displays as {"a":[null,"2020-02-18T06:38:55-0500",1,"f","2020-02-1….
Dummy ISBN
Precat Dummy title
Precat Dummy author
Floating group (display not tested)

Displaying # code rather than text value:
Loan duration
Fine Level

In sandbox, acq cost is labelled cost. I think acq cost is clearer.

Also, Quality is “is mint condition” I think it should remain quality since that is what it is called in holdings editor

[Elaine Hardy (ehardy)]

I will check this again. THe fix may not have been on the sandbox.

[Janet Schrader (jschrader)]

Can confirm Elaine's comment:
Loan duration and Fine level displaying # code instead of text
Alert message doesn't display

Can confirm:
Floating group: displays text OK

Missing from column picker:
Parts

Should these be "Item" instead of "Copy" now that terminology has changed?
Copy ID
Copy Status
Copy Status Changed Time

What is this?
Copy Number on Volume

[Terran McCanna (tmccanna)]

Removed pullrequest after discussing with Tiffany