Institution tags

[Stacey Walker]

We have a client who has a requirement to define and manage a set of institutional tags which members can use for tagging portfolio content.

These tags must be:
- configured disabled per institution by default with the ability to enable
- only visible and selectable by institutional members
- clearly identifiable as institutional tags when selecting and filtering
-- and which institution if the user belongs to multiple using this feature
- non-editable by members outside of the institutional tag management screens

It is believed that this feature would make a good addition to Mahara core and could be extended in the future to helping with other features such as SmartEvidence classifications etc.

[Kristina Hoeppner (kris-hoeppner)]

This is a very good addition to the current tagging and had come up previously with group tags as well, just not yet implemented.

What will be important to consider is the display of these tags (could be site and group tags in the future as well) so that we are not ending up with 2 or more menus where to input tags. It should still be easy for people to do like it is at the moment.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8585

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8588

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8587

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8609

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8608

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8612

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8611

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8614

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8613

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8615

[Kristina Hoeppner (kris-hoeppner)]

Screenshot relates to https://reviews.mahara.org/#/c/8614/19

Because institution tags are very long, they have an ellipsis on the "My tags" page. This can get ambigious quite quickly as crucial information is not displayed. Two options:

1) Don't use an ellipsis. Then we can get into problems when they are very long and need to be shown on two lines as they'd probably not break.

2) Keep the ellipsis but have tooltips for the tags so that they can be displayed in full on hover.

[Kristina Hoeppner (kris-hoeppner)]

Furthermore, the ellipsis is not accessible because the screenreader does not get the full tag.

So no matter which option is selected, it needs to be checked that a screenreader can read the full tag.

[Kristina Hoeppner (kris-hoeppner)]

The tag box is too short for institution tags in a number of cases. This is the case for example on the tagged journal entries config screen as well as on the page settings screen.

[Steven (stevens-q)]

The identifiable part of the institutional tags (ie <institution name>) is not used in the autosuggestion

Given that the Institution tag is named xyz - when it is displayed in the auto- suggestion area it is appended to the <institution name>xyz
however the first part of the new tag ("institution name: xyz") is not searched for.

A user could not search for "Inst" and get "institution name: xyz", They would have to type x, y or z to get the desired tag "xyz"

[Steven (stevens-q)]

Selecting a tag from the auto suggestion and actually typing in the whole institution tag will result in 2 tags with the same displayed name
------------------------------------------
in the "tag" table in the database the ID for an institution tags in "tagid_<number>" In the database this is technically different, it will display the identical name when viewing in the frontend

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8960

[Steven (stevens-q)]

Bug 1722861 Institution tags
==================================================
Created Thursday 14 June 2018

The institution/site admins can delete the
institution tags that have not been used
by any user.

If a tag has been used, instead of the
delete icon, the admins will see how
many times the tag has been used.
--------------------------------------------------------------------------
Launchpad: https://bugs.launchpad.net/mahara/+bug/1722861
Gerrit: https://reviews.mahara.org/#/c/8613/
Bug description: Allow admins to delete institution tag
--------------------------------------------------------------
Environment tested: Master
Browser tested: Chrome

-------------------------------------
Manual Test Script
-------------------------------------

#### Acceptance Criteria ####
These tags must be:
1. configured / disabled per institution by default with the ability to enable ✔
2. only visible and selectable by institutional members
 a. Site admin (create and delete - if tag has not been used)
 b. Institution admin (create and delete - if tag has not been used)
 c. Institution staff (use)
 d. Institution member (use)
3. clearly identifiable as institutional tags when selecting and filtering, i.e. the institution name is displayed before the tag. ✔
4. and which institution if the user belongs to multiple using this feature ✔
5. non-editable by members outside of the institutional tag management screens ✔
================================================================================

Preconditions:

1. MYSQL / PostgreSQL database used
2. Site Admin set the following
 a. create 2 Institutions (Institution A & Institution B)
 b. Allow institution tags for both Institutions = Yes
 c. Create user to be Institution A admin (Alice User1)
 d. Create user to be Institution A staff (Dan User4)
 e. Create user to be Institution A member (Carol User3)
 f. Create user to be Institution B admin (Bob User2)
 g. Create user to be Institution B member (Fred User6)
 h. Create user to be Institution member (Earl User5) of both Institution A and Institution B
3. Site admin creates a tag (official X24578A) & (Institution A tag)
4. Site admin creates a tag (official QUVW) & (Institution B tag)

Test Script: Inst admin create/delete Institution tags

1. Log in as Institution admin (Alice User1)
2. Browse to Admin menu > Institutions > Tags
3. Create a tag (AB234-Dec-2018)
4. Create a tag (QinstB-5567)
5. Confirm Inst admin can delete inst Tag when it has not yet been used. ✔
6. Browse to any place that uses tags (ie portfolio page)
7. Type the first letter of the known tag's name
8. Confirm the auto-suggestion displays the desired tag ✔
9. Confirm that once a tag has been used that Inst admin cannot delete tag ✔
10. Log in as Institution A staff (Dan User4)
11. Confirm that staff cannot edit the Admin menu > Institutions > Tags page ✔
12. Log in as Institution B admin (Bob User2)
13. Create a tag (QXYZ)
14. Create tag (QLMNOP)
15. Browse to any place that uses tags (ie edit image file)
16. Type the first letter of the known tag's name
17. Confirm the auto-suggestion displays the desired tag ✔
18. Confirm tags for Institution A are not displayed ✔
19. Conf...

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8964

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8614
Committed: https://git.mahara.org/mahara/mahara/commit/dce59fe6417f4b12f8a778260825a928990da01e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit dce59fe6417f4b12f8a778260825a928990da01e
Author: Maria Sorica <email address hidden>
Date: Fri Mar 9 16:27:18 2018 +0000

Bug 1722861: Display tag prefix on tagged journal search

Change-Id: I833caaa90b2640c3902c81d96ffaf451489abbcb

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8609
Committed: https://git.mahara.org/mahara/mahara/commit/fe026d2ffb6a85cb673c651a41ae24367a9d024d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit fe026d2ffb6a85cb673c651a41ae24367a9d024d
Author: Maria Sorica <email address hidden>
Date: Thu Mar 8 17:08:51 2018 +0000

Bug 1722861: Select and save institution tags

The user can tag artefacts, collections and views
with the institution tags (if he is part of that
institution).

The institution name appears in front of
the institution tag to differentiate itself
from the other tags.

Change-Id: I6b71ed160ecf20fb7813bf127ad34b30432ba7af

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8612
Committed: https://git.mahara.org/mahara/mahara/commit/057900f9678534ebc58d0d76f86ef292fd70dc49
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 057900f9678534ebc58d0d76f86ef292fd70dc49
Author: Maria Sorica <email address hidden>
Date: Fri Mar 9 13:36:31 2018 +0000

Bug 1722861: Fix the institution tags display on tags.php

1. On the tags.php page the institution tags
shoud be displayed with the institution
name as prefix.
2. The institution tags should not be available
for editing.
3. Fixed the side block display as well.

Change-Id: I4383f3ec6c6976a40897c406887c49c2a219c644

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8611
Committed: https://git.mahara.org/mahara/mahara/commit/0704eccbdc078702a09257249b43c3f183577a4a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0704eccbdc078702a09257249b43c3f183577a4a
Author: Maria Sorica <email address hidden>
Date: Fri Mar 9 11:14:09 2018 +0000

Bug 1722861: On file edit, display the tag prefix

Change-Id: I665d03d083e217647e00e64ab5573e263534276c

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8613
Committed: https://git.mahara.org/mahara/mahara/commit/1ea2673bf86a49a21f9d285d0f31806becbc5430
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1ea2673bf86a49a21f9d285d0f31806becbc5430
Author: Maria Sorica <email address hidden>
Date: Fri Mar 9 16:16:48 2018 +0000

Bug 1722861: Allow admins to delete institution tag

The institution/site admins can delete the
institution tags that have not been used
by any user.

If a tag has been used, instead of the
delete icon, the admins will see how
many times the tag has been used.

Change-Id: I29be28c2b62e278952412f9e648eba5dd9e0ed91

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8588
Committed: https://git.mahara.org/mahara/mahara/commit/e11863f8a1bc4cdccb70291766a6c33d9af3bd23
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e11863f8a1bc4cdccb70291766a6c33d9af3bd23
Author: Maria Sorica <email address hidden>
Date: Wed Mar 7 17:12:15 2018 +0000

Bug 1722861: Add the create institution tag logic

1. Added the create tag form on the institution
tags page.
2. Store the isntitution tag in the "tag" table.

Change-Id: I837ec4137758d28d8a42c7629433b92f04a82600

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8587
Committed: https://git.mahara.org/mahara/mahara/commit/fd5dc8fac300ecfc314cabfabd4a780df86ffd5c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit fd5dc8fac300ecfc314cabfabd4a780df86ffd5c
Author: Maria Sorica <email address hidden>
Date: Wed Mar 7 15:42:55 2018 +0000

Bug 1722861: Add the institution tags page

1. If a visible institution enables the
institution tags, a "Tags" link will appear
under the Institutions menu.

2. The link will take the user to the
institution tags page.

Change-Id: I29b2777c34253ebf57d0a3bd294081b7727cdc9b

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8585
Committed: https://git.mahara.org/mahara/mahara/commit/8858f4972e3609aa1832e7c25135c177ff47b950
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 8858f4972e3609aa1832e7c25135c177ff47b950
Author: Maria Sorica <email address hidden>
Date: Tue Mar 6 17:41:51 2018 +0000

Bug 1722861: Add the option to use institution tags

On the institution settings page,admins
are able to turn "Allow institution tags" on.

Change-Id: I404f74c56aac435465c4bd67128d1c262405d5c3

[Steven (stevens-q)]

BUG: Unable to delete personal user tags with same prefix as institution

User types Institution prefix and a personal unique tag end for a tag
User can see the tag on the edit tags page
User can edit the specific tag and delete it
After clicking the delete button the page reloads but the tag is still displayed - the tag is also still displayed on the artifact /content object in the displayed page

BUG: admin can still delete Institution tag even if it has been used

Admin creates an Institution tags
Admin creates a portfolio page and selects the Institution tag from the auto suggestion
Admin Saves the new page
Admin browses to the My tags page
The Institution tag is displayed as expected
Admin browse to the Institution tags page
The tag is displayed but the admin can still delete the tag
Expected to see the number of times the tag was used once the tag has been used by someone

[Steven (stevens-q)]

Test Script Scenario: Member of Inst B Drops out of Inst B
============================================
Preconditions:
------------------
1. MYSQL / PostgreSQL database used
2. Site Admin set the following
 a. create 2 Institutions (Institution A & Institution B)
 b. Allow institution tags for both Institutions = Yes
 c. Create user to be Institution B member (Fred User6)
3. Site admin creates a tag (official X24578A) & (Institution A tag)
4. Site admin creates a tag (official QUVW) & (Institution B tag)
5. Institution B member (Fred User6) Leaves Institution B
6. Institution B admin creates a new Inst B tag (Q- New InstB tag) after Inst B B member (Fred User6) leaves Institution

Test Script:
----------------
1. Log in as Institution B member (Fred User6)
2. Institution B member creates a new Portfolio page
3. Confirm the following when entering a tag in the tag field
--- a. user can still see old Institution tags used ✔
--- b. user cannot see any new Institution tags created after user has left Institution ✔
--- c. user can create a new tag
4. Browse to My tags page
5. Confirm that the user is now able to edit the old Instutution tags ✔

Catalyst QA Approved ✔

[Steven (stevens-q)]

#####Test Script Scenario: User types in tag rather than using the auto - suggest functionality of the tags field

#####Preconditions:
1. PostgreSQL database used
2. Site Admin set the following
   - create 2 Institutions (Institution A & Institution B)
   - Allow institution tags for both Institutions = Yes
 c. Create user to be Institution B member (Fred User6)
3. Institution A - Institution tags are as follows :
   - Q-instaTAG-7654
   - Q-instaTAG-8555
4. Institution B - Institution tags are as follows :
   - Q-instBTAG 12345
   - Q-instBTAG 9909
   - Q- NEW Inst B Tag
5. Institution B member (Fred User6) Leaves Institution B
6. Institution B admin creates a new Inst B tag (Q- New InstB tag) after Inst B B member (Fred User6) leaves Institution

#####Test script:
1. Log in as Institution B member (Fred User6)
2. Institution B member creates a new Portfolio page
3. Confirm the following when entering first 3 letters of the Institution tag prefix tag in the tag field
   - user can User can see Auto suggestions that statr with the first 3 letters typed in the tag field ✔
   - user cannot see any Institution tags That they do not belong to ✔
   - user can create a new tag or click on a suggested tag
4. Browse to My tags page
5. Confirm that the user is now able to edit the old Instutution tags ✔

[Steven (stevens-q)]

Bug 1722861 Institution tags
==================================================
Created Friday 22 June 2018

**Summary**
- The institution/site admins can delete the
institution tags that have not been used
by any user.

- If a tag has been used, instead of the
delete icon, the admins will see how
many times the tag has been used.

**Launchpad** https://bugs.launchpad.net/mahara/+bug/1722861

**Gerrit:** https://reviews.mahara.org/#/c/8964/

**Bug description:** Institution tags

#### Environment tested: Master
#### Browser tested: Chrome

-------------------------------------
Re Test Manual Test Script
-------------------------------------

####Background :

Given the following institutions exist:
 - Institution A
    - Institution tag = Q-InstA-Tag-123
    - Institution tag = Q-InstA-Tag-456
 - Institution B
    - Institution tag = Q-InstB-Tag-987
    - Institution tag = Q-InstB-Tag-654

Given the following Users exist:
- InstAAdmin
- InstAMember
- InstBAdmin
- InstBMember

Scenario: Users are able to delete "user created tags" and cannot delete "Institution tags"

    Given I log in as InstBAdmin
    And I create a Portfolio page
    And I fill in the tag field useing auto-suggest to select the Institution tag "Institution B: Q-InstB-Tag-987"
    And I fill in the tag field by typing in a user created tag "User created tag"
    When I browse to the "My tags page"
    And I click the editbutton
    Then I should see my user created tag "User created tag"
    And I should not see Institution tag "Institution B: Q-InstB-Tag-987"
    And I should be able to delete my user created tag "User created tag"

Scenario: Once an institution tag is used, it cannot be deleted

    Given I log in as InstBAdmin
    And I create a Portfolio page
    And I fill in the tag field useing auto-suggest to select the Institution tag "Institution B: Q-InstB-Tag-987"
    When I browse to "Institution tags" page
    Then I should see "Used tags can't be deleted" text to the right of the "Institution B: Q-InstB-Tag-987" Institution Tag
    And I should see a delete icon to the right of the "Institution tag = Q-InstB-Tag-654" institution tag
    And I should see both Institution tags displayed in a table with the heading Tags and times used.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8964
Committed: https://git.mahara.org/mahara/mahara/commit/1061521345b26f3ee0e47944416493f35fba4fcf
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1061521345b26f3ee0e47944416493f35fba4fcf
Author: Maria Sorica <email address hidden>
Date: Tue Jun 19 11:08:06 2018 +0100

Bug 1722861: Display institution tags in a table

On the admin page of institution tags (/admin/users/institutiontags.php),
display tags in a table.

behatnotneeded

Change-Id: I9a5a7c6fd6d4c5fad3ba127d6df87d684d19d7b2

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8960
Committed: https://git.mahara.org/mahara/mahara/commit/bb9335344ff1256faeb7fc533438e78927d26fc8
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit bb9335344ff1256faeb7fc533438e78927d26fc8
Author: Robert Lyon <email address hidden>
Date: Tue Jun 19 09:07:41 2018 +1200

Bug 1722861: Restricting use of institution tags

If we are not a member of the institution we shouldn't be able to use
the institution tag

Also, if we leave the institution, the references of institution tags we are using
should be turned into normal tags for us

behatnotneeded

Change-Id: I5e8eb270a995fd5b556c72707ead48b767e1f686
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8964
Committed: https://git.mahara.org/mahara/mahara/commit/1061521345b26f3ee0e47944416493f35fba4fcf
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1061521345b26f3ee0e47944416493f35fba4fcf
Author: Maria Sorica <email address hidden>
Date: Tue Jun 19 11:08:06 2018 +0100

Bug 1722861: Display institution tags in a table

On the admin page of institution tags (/admin/users/institutiontags.php),
display tags in a table.

behatnotneeded

Change-Id: I9a5a7c6fd6d4c5fad3ba127d6df87d684d19d7b2