Some core plugins have their own style/style.css files not controlled via sass

Bug #1721623 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic

Bug Description

This means they exist for 'raw' theme but not 'raw_old' theme

For example: openbadges block, externalfeed block, etc.

To fix we either need to do:

A) Copy the same css files to the old raw theme as well (simple option)

 or

B) Get these styles handled within sass itself (more robust option)

This became a problem when we decided to have 2 'root' theme options in Mahara. Hopefully we move to only having one again in the future.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8096

Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
status: Confirmed → In Progress
Revision history for this message
Robert Lyon (robertl-9) wrote :

I notice that putting the styles into sass has now made some things look incorrect

See attached before / after for Portfolio -> Export page

Revision history for this message
Robert Lyon (robertl-9) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8096
Committed: https://git.mahara.org/mahara/mahara/commit/80c4b1401dc05573986be5e26c7b660fa57f8b2d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 80c4b1401dc05573986be5e26c7b660fa57f8b2d
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 6 15:02:11 2017 +1300

Bug 1721623: added plugin's css to be controlled by sass

For both raw and raw_old

Not moving files that are only used for styling
html exported static page:

theme/raw/plugintype/export/html/style/style.css
theme/raw/plugintype/export/html/style/print.css

theme/raw/plugintype/artefact/internal/export/html/style/style.css
 used only in exported static page:
 <path-to-static-page>/files/internal/index.html

theme/raw/plugintype/artefact/resume/export/html/style/style.css
 used only in exported static page:
 <path-to-static-page>/files/resume/index.html

the same for raw_old

Change-Id: Ief02aaee3bd86a30c6cae529953500a3a36ca8c9
behatnotneeded: styles

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8138

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8138
Committed: https://git.mahara.org/mahara/mahara/commit/ba098c6bedf94b860c79ab0594b333a488729344
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit ba098c6bedf94b860c79ab0594b333a488729344
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 6 15:02:11 2017 +1300

Bug 1721623: added plugin's css to be controlled by sass

For both raw and raw_old

Not moving files that are only used for styling
html exported static page:

theme/raw/plugintype/export/html/style/style.css
theme/raw/plugintype/export/html/style/print.css

theme/raw/plugintype/artefact/internal/export/html/style/style.css
 used only in exported static page:
 <path-to-static-page>/files/internal/index.html

theme/raw/plugintype/artefact/resume/export/html/style/style.css
 used only in exported static page:
 <path-to-static-page>/files/resume/index.html

the same for raw_old

Change-Id: Ief02aaee3bd86a30c6cae529953500a3a36ca8c9
behatnotneeded: styles
(cherry picked from commit 80c4b1401dc05573986be5e26c7b660fa57f8b2d)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: 17.10rc2 → 17.10.0
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.