Redirect to incorrect port when sslproxy is on and wwwroot is set

[Dmitrii Metelkin]

When you have your mahara behind SSL proxy and have sslproxy enabled, it redirects to incorrect port when you try to access pages which require login.

When you get your mahara behind load balancer and nginx proxy on port 81 you get redirected to https://mahara.com:81/user/admin?login when try to access https://mahara.com/user/admin as not logged in user.

Looks like function get_full_script_path tries to get a port even if $CFG->wwwroot is set.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8073

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8073
Committed: https://git.mahara.org/mahara/mahara/commit/4655c27f6238130e58ef051872573c4a8ba58f8b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4655c27f6238130e58ef051872573c4a8ba58f8b
Author: Dmitrii Metelkin <email address hidden>
Date: Fri Sep 29 11:34:01 2017 +1000

Bug 1717861: fix incorrect full script path when using sslproxy

behatnotneeded

Change-Id: I0ea71a5402889e41dc121e26ddde8bf020e9e76f

[Mahara Bot (dev-mahara)]

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8080

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8080
Committed: https://git.mahara.org/mahara/mahara/commit/ad75d872e26f02295a36c296e2c2dccc7753394c
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit ad75d872e26f02295a36c296e2c2dccc7753394c
Author: Dmitrii Metelkin <email address hidden>
Date: Fri Sep 29 11:34:01 2017 +1000

Bug 1717861: fix incorrect full script path when using sslproxy

behatnotneeded

Change-Id: I0ea71a5402889e41dc121e26ddde8bf020e9e76f
(cherry picked from commit 4655c27f6238130e58ef051872573c4a8ba58f8b)

[Ghada El-Zoghbi (ghada-z)]

Hi Robert / Kristina,

Is there a reason why this is not getting cherry-picked into 16.10? We have the same issue happening on that version.

Thanks,
Ghada

[Kristina Hoeppner (kris-hoeppner)]

Hi Ghada,

It's not backported as it is not high priority or a security issue. You can backport it yourself though.

Cheers
Kristina