Mahara

Incorrect port in SimpleSAML when sslproxy is enabled

Bug #1717133 reported by Dmitrii Metelkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Dmitrii Metelkin
Mahara 17.10.0

Bug Description

When we enable sslproxy because we use SSL proxy, SAML incorrectly picks port when builds self URL in getSelfURL function of SimpleSAML\Utils\HTTP class.

Instead of https://mahara.catalyst-au.net/auth/saml/index.php?idpentityid=http://catalyst.edu.au/adfs/services/trust

It returns Instead of https://mahara.catalyst-au.net:81/auth/saml/index.php?idpentityid=http://catalyst.edu.au/adfs/services/trust

See original description
Dmitrii Metelkin (dmitriim)
Changed in mahara:
assignee: nobody → Dmitrii Metelkin (dmitriim)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8013

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 17.10.0
status: New → In Progress
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8013
Committed: https://git.mahara.org/mahara/mahara/commit/c01b02cb3c598218f1775d7cb496e2c8300e9042
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c01b02cb3c598218f1775d7cb496e2c8300e9042
Author: Dmitrii Metelkin <email address hidden>
Date: Thu Sep 14 10:42:34 2017 +1000

Bug 1717133: set correct port if we use SAML and sslproxy is enabled

behatnotneeded

Change-Id: Ieea98e63ba9db15613f28ad34b95ed4177aba3e9

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.