Network Connectivity Checking does not turn gray when toggle is set to Off

Bug #1715662 reported by motang
24
This bug affects 5 people
Affects Status Importance Assigned to Milestone
gnome-control-center (Ubuntu)
Fix Released
Low
James Henstridge

Bug Description

The background Network Connectivity Checking does not turn gray when the toggle is set to Off. Still has orange background. See attached image.

ProblemType: Bug
DistroRelease: Ubuntu 17.10
Package: gnome-control-center 1:3.24.3-0ubuntu6
ProcVersionSignature: Ubuntu 4.12.0-13.14-generic 4.12.10
Uname: Linux 4.12.0-13-generic x86_64
ApportVersion: 2.20.7-0ubuntu1
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Thu Sep 7 09:42:59 2017
InstallationDate: Installed on 2017-08-23 (14 days ago)
InstallationMedia: Ubuntu 17.10 "Artful Aardvark" - Alpha amd64 (20170820)
JournalErrors:
 Error: command ['journalctl', '-b', '--priority=warning', '--lines=1000'] failed with exit code 1: Hint: You are currently not seeing messages from other users and the system.
       Users in the 'systemd-journal' group can see all messages. Pass -q to
       turn off this notice.
 No journal files were opened due to insufficient permissions.
ProcEnviron:
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: gnome-control-center
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

Revision history for this message
motang (mohan-ram) wrote :
Jeremy Bícha (jbicha)
Changed in gnome-control-center (Ubuntu):
status: New → Confirmed
Revision history for this message
Iain Lane (laney) wrote :

I know why this happens, and I posted it as a review on the upstream bug (#737362)

@@ +1300,3 @@
+{
+ nm_client_connectivity_check_set_enabled (client, state);
+ return TRUE;

You should return FALSE here, so the default signal handler runs. This is the cause of https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1715662

Revision history for this message
Sebastien Bacher (seb128) wrote :

James, could you update your patch upstream and maybe submit a package update for Ubuntu as well?

tags: added: rls-aa-incoming
Changed in gnome-control-center (Ubuntu):
assignee: nobody → James Henstridge (jamesh)
importance: Undecided → Low
Changed in gnome-control-center (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-control-center - 1:3.26.0-0ubuntu2

---------------
gnome-control-center (1:3.26.0-0ubuntu2) artful; urgency=medium

  [ James Henstridge ]
  * debian/patches/connectivity-switch.patch: watch the correct property
    so the connectivity switch updates correctly. (LP: #1715662)

  [ Didier Roche ]
  * debian/patches/ubuntu-printer-support.patch: (LP: #1718083)
    - Temporary add an additional advanced printer button.
      g-c-c printers panel doesn't support printer sharing and other
      features.
      Workaround it for now by adding in multiple places an advanced printer
      button starting system-config-printer to avoid doubling the panel
      in Settings.
  * debian/patches/ubuntu-language-support.patch:
    clean up ui file and align right, as for advanced printer setttings button.
  * debian/patches/71_ubuntu_dock_settings.patch: (LP: #1718612)
    - as suggested by the community, change label "screen position" by
      "position on screen"
    - change margin to match other panels
    - only display "show on" when having multiple displays

 -- Didier Roche <email address hidden> Fri, 22 Sep 2017 07:22:35 +0200

Changed in gnome-control-center (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.