SAML Service Provider Metadata link should be hidden if SSPHP is not installed

Bug #1715544 reported by Dmitrii Metelkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Dmitrii Metelkin

Bug Description

Not a huge thing, but it will make a page a little bit cleaner.

If on the page /admin/extensions/pluginconfig.php?plugintype=auth&pluginname=saml we see message like

The SimpleSAMLPHP library's "autoloader" file was not found at /var/www/site/auth/saml/extlib/simplesamlphp/vendor/autoload.php.
Make sure you install SimpleSAMLphp via "make ssphp" and the file is readable.

we probably need to get rid of Metadata link which doesn't work anyway in this case and just displays a broken page.

Changed in mahara:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8162

Changed in mahara:
assignee: nobody → Dmitrii Metelkin (dmitriim)
status: Confirmed → In Progress
Changed in mahara:
milestone: none → 18.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8162
Committed: https://git.mahara.org/mahara/mahara/commit/9c40678109a360724d81b4eae275d2a1d2a32d8c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9c40678109a360724d81b4eae275d2a1d2a32d8c
Author: Dmitrii Metelkin <email address hidden>
Date: Thu Oct 19 14:36:32 2017 +1100

Bug 1715544: hide metadata link when SSPHP is not configured

behatnotneeded

Change-Id: I24895a80f49820212e3708592a4cd4638a8fe2d8

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8178

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8178
Committed: https://git.mahara.org/mahara/mahara/commit/00dd3a0093265a051a54999377f569191dc8f525
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 00dd3a0093265a051a54999377f569191dc8f525
Author: Dmitrii Metelkin <email address hidden>
Date: Thu Oct 19 14:36:32 2017 +1100

Bug 1715544: hide metadata link when SSPHP is not configured

behatnotneeded

Change-Id: I24895a80f49820212e3708592a4cd4638a8fe2d8
(cherry picked from commit 9c40678109a360724d81b4eae275d2a1d2a32d8c)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 18.04.0 → 17.10.0
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.