[SRU] New stable micro release 2.34

[Sergio Schvezov]

This is an SRU bug to release 2.34 of snapcraft which follows the guidelines defined in the wiki over at https://wiki.ubuntu.com/SnapcraftUpdates

The list of bugs and features in this release are defined at https://launchpad.net/snapcraft/+milestone/2.34 and https://github.com/snapcore/snapcraft/milestone/9?closed=1

[Launchpad Janitor (janitor)]

This bug was fixed in the package snapcraft - 2.34+17.10

---------------
snapcraft (2.34+17.10) artful; urgency=medium

  [ Sergio Schvezov ]
  * core: cache FileBase entries when a checksum is provided (#1433)
  * cli: better error message for missing mksquashfs (#1481)
  * core: improve source caching logic (#1486)
  * ci: speedup the CLA check (#1503)
  * ci: disable the travis deploy stage for docs (#1510)
  * vcs: ignore .vscode project settings (#1517)
  * docs: add github processed templates (#1514)
  * tour: remove the tour assets (#1520)
  * project: introduce build-snaps (#1518)
  * tests: update the meson test to latest meson requirements (#1532)
  * jhbuild plugin: remove dependency on pkgconf (#1535)
  * nodejs plugin: add prefix --prefix to global pkg add (#1539)
  * New upstream release (LP: #1715399)

  [ Christian Dywan ]
  * lxd: clean with no parts should only delete (#1434)
  * lxd: inject snapcraft and core snaps into the container (#1364)
  * lxd: wait on lock files before running apt commands (#1435)
  * kbuild plugin: support Makefiles without an install target (#1432)
  * kbuild plugin: move over the cross-compiling logic from the kernel plugin (#1417)
  * lxd: path cannot have extra forward slashes (#1483)
  * lxd: always remove existing device for project folder (#1488)
  * lifecycle: outdated step should raise SnapcraftError (#1513)
  * errors: introduce ContainerError (#1505)
  * lxd: LXD not installed when using remote (#1516)
  * lxd: use a unique temporary folder (#1519)

  [ Leo Arias ]
  * recording: record the original snapcraft.yaml (#1407)
  * ci: skip the CLA check for pull requests from the bot (#1482)
  * docs: fix typo in plugin help (#1496)
  * python plugin: record manifest (#1487)
  * tests: use assertThat instead of assertEqual (#1501)
  * python plugin: always record constraints and requirements contents (#1521)
  * demos: update the name of the remote mqtt part (#1533)

  [ Kyle Fazzari ]
  * options: properly handle missing compiler prefix (#1425)
  * catkin plugin: include-roscore is a boolean (#1472)
  * catkin plugin: default to release build (#1470)
  * catkin plugin: rosinstall-files is a pull property (#1473)
  * catkin plugin: support passing args to cmake (#1471)
  * catkin plugin: extract rosdep into new package (#1392)
  * cli: add global exception handler
  * cli: stop handling exceptions in lifecycle
  * plugins: use exceptions based on SnapcraftError
  * cli: stop handling exceptions in parts
  * cli: stop handling exceptions in assertions
  * cli: stop handling exceptions in store
  * many: use exceptions based on SnapcraftError
  * rosdep: add support for multiple dependency types (#1479)
  * errors: use function for exit code (#1491)
  * cli: don't raise from excepthook (#1495)
  * repo: make errors based on SnapcraftError (#1499)
  * project loader: refactor into package (#1504)
  * grammar: move into project_loader (#1500)
  * many: simplify plugin loading (#1507)
  * schema: version should have a max length of 32 (#1508)
  * project_loader: process stage package grammar (#1509)
  * project_loader: support grammar on build-packages (#1511)

  [ Alex T Newman ]
  * windows: add...

[Sergio Schvezov (sergiusens)]

From our CI for this release:
xenial-amd64 autopkgtest finished (success)
xenial-arm64 autopkgtest finished (success)
xenial-armhf autopkgtest finished (success)
zesty-amd64 autopkgtest finished (success)
zesty-arm64 autopkgtest finished (success)
zesty-armhf autopkgtest finished (success)

[Łukasz Zemczak (sil2100)]

Hello Sergio, or anyone else affected,

Accepted snapcraft into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.34+17.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Łukasz Zemczak (sil2100)]

Hello Sergio, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.34 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Leo Arias (elopio)]

Before this update lands in the -update pockets, the following tests need to pass:

Container builds:

 * Clean the project without arguments:

     `SNAPCRAFT_CONTAINER_BUILDS=1 snapcraft clean`

Plugins:

 * Build a snap with the catkin plugin.
 * Build a snap with the jhbuild plugin.

Errors:

 * Try to build a snap without mksquashfs.

Exploratory:

 * Use build-snaps to build snaps.
 * Build the same snap multiple times, to check the caching.
 * Build snaps with the nodejs plugin and yarn.
 * Build snaps with SNAPCRAFT_CONTAINER_BUILDS=1 using local and remote LXD.
 * Build snaps with SNAPCRAFT_BUILD_INFO=1, check the manifest.yaml in the prime/snap directory.
 * Try to get as many errors as possible, check the error messages or the trace returned when running with `--debug`.
 * Build snaps with grammar in build and stage packages.

[Leo Arias (elopio)]

I've successfully run the tests in xenial, zesty and artful LXD containers, testing the upgrade and then making various snaps to exercise the new features in this release, plus exploratory.

I couldn't find any blockers, so I'm marking this as verified.

Thanks Łukasz!

[Łukasz Zemczak (sil2100)]

There seems to be an autopkgtest failure on armhf for both xenial and zesty but from the test result it seems to be the usual flakiness of the integration tests on this architecture. Seeing the test history it's not the first time those are failing. We might consider adding a hint for it.
But could someone look into any possibilities of making this more reliable on armhf? Or, if it's not possible, maybe disabling some tests when run on this architecture?

Anyway, accepting this to -updates now.

[Launchpad Janitor (janitor)]

This bug was fixed in the package snapcraft - 2.34+17.04

---------------
snapcraft (2.34+17.04) zesty; urgency=medium

  [ Sergio Schvezov ]
  * core: cache FileBase entries when a checksum is provided (#1433)
  * cli: better error message for missing mksquashfs (#1481)
  * core: improve source caching logic (#1486)
  * ci: speedup the CLA check (#1503)
  * ci: disable the travis deploy stage for docs (#1510)
  * vcs: ignore .vscode project settings (#1517)
  * docs: add github processed templates (#1514)
  * tour: remove the tour assets (#1520)
  * project: introduce build-snaps (#1518)
  * tests: update the meson test to latest meson requirements (#1532)
  * jhbuild plugin: remove dependency on pkgconf (#1535)
  * nodejs plugin: add prefix --prefix to global pkg add (#1539)
  * New upstream release (LP: #1715399)

  [ Christian Dywan ]
  * lxd: clean with no parts should only delete (#1434)
  * lxd: inject snapcraft and core snaps into the container (#1364)
  * lxd: wait on lock files before running apt commands (#1435)
  * kbuild plugin: support Makefiles without an install target (#1432)
  * kbuild plugin: move over the cross-compiling logic from the kernel plugin (#1417)
  * lxd: path cannot have extra forward slashes (#1483)
  * lxd: always remove existing device for project folder (#1488)
  * lifecycle: outdated step should raise SnapcraftError (#1513)
  * errors: introduce ContainerError (#1505)
  * lxd: LXD not installed when using remote (#1516)
  * lxd: use a unique temporary folder (#1519)

  [ Leo Arias ]
  * recording: record the original snapcraft.yaml (#1407)
  * ci: skip the CLA check for pull requests from the bot (#1482)
  * docs: fix typo in plugin help (#1496)
  * python plugin: record manifest (#1487)
  * tests: use assertThat instead of assertEqual (#1501)
  * python plugin: always record constraints and requirements contents (#1521)
  * demos: update the name of the remote mqtt part (#1533)

  [ Kyle Fazzari ]
  * options: properly handle missing compiler prefix (#1425)
  * catkin plugin: include-roscore is a boolean (#1472)
  * catkin plugin: default to release build (#1470)
  * catkin plugin: rosinstall-files is a pull property (#1473)
  * catkin plugin: support passing args to cmake (#1471)
  * catkin plugin: extract rosdep into new package (#1392)
  * cli: add global exception handler
  * cli: stop handling exceptions in lifecycle
  * plugins: use exceptions based on SnapcraftError
  * cli: stop handling exceptions in parts
  * cli: stop handling exceptions in assertions
  * cli: stop handling exceptions in store
  * many: use exceptions based on SnapcraftError
  * rosdep: add support for multiple dependency types (#1479)
  * errors: use function for exit code (#1491)
  * cli: don't raise from excepthook (#1495)
  * repo: make errors based on SnapcraftError (#1499)
  * project loader: refactor into package (#1504)
  * grammar: move into project_loader (#1500)
  * many: simplify plugin loading (#1507)
  * schema: version should have a max length of 32 (#1508)
  * project_loader: process stage package grammar (#1509)
  * project_loader: support grammar on build-packages (#1511)

  [ Alex T Newman ]
  * windows: add ...

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for snapcraft has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package snapcraft - 2.34

---------------
snapcraft (2.34) xenial; urgency=medium

  [ Sergio Schvezov ]
  * core: cache FileBase entries when a checksum is provided (#1433)
  * cli: better error message for missing mksquashfs (#1481)
  * core: improve source caching logic (#1486)
  * ci: speedup the CLA check (#1503)
  * ci: disable the travis deploy stage for docs (#1510)
  * vcs: ignore .vscode project settings (#1517)
  * docs: add github processed templates (#1514)
  * tour: remove the tour assets (#1520)
  * project: introduce build-snaps (#1518)
  * tests: update the meson test to latest meson requirements (#1532)
  * jhbuild plugin: remove dependency on pkgconf (#1535)
  * nodejs plugin: add prefix --prefix to global pkg add (#1539)
  * New upstream release (LP: #1715399)

  [ Christian Dywan ]
  * lxd: clean with no parts should only delete (#1434)
  * lxd: inject snapcraft and core snaps into the container (#1364)
  * lxd: wait on lock files before running apt commands (#1435)
  * kbuild plugin: support Makefiles without an install target (#1432)
  * kbuild plugin: move over the cross-compiling logic from the kernel plugin (#1417)
  * lxd: path cannot have extra forward slashes (#1483)
  * lxd: always remove existing device for project folder (#1488)
  * lifecycle: outdated step should raise SnapcraftError (#1513)
  * errors: introduce ContainerError (#1505)
  * lxd: LXD not installed when using remote (#1516)
  * lxd: use a unique temporary folder (#1519)

  [ Leo Arias ]
  * recording: record the original snapcraft.yaml (#1407)
  * ci: skip the CLA check for pull requests from the bot (#1482)
  * docs: fix typo in plugin help (#1496)
  * python plugin: record manifest (#1487)
  * tests: use assertThat instead of assertEqual (#1501)
  * python plugin: always record constraints and requirements contents (#1521)
  * demos: update the name of the remote mqtt part (#1533)

  [ Kyle Fazzari ]
  * options: properly handle missing compiler prefix (#1425)
  * catkin plugin: include-roscore is a boolean (#1472)
  * catkin plugin: default to release build (#1470)
  * catkin plugin: rosinstall-files is a pull property (#1473)
  * catkin plugin: support passing args to cmake (#1471)
  * catkin plugin: extract rosdep into new package (#1392)
  * cli: add global exception handler
  * cli: stop handling exceptions in lifecycle
  * plugins: use exceptions based on SnapcraftError
  * cli: stop handling exceptions in parts
  * cli: stop handling exceptions in assertions
  * cli: stop handling exceptions in store
  * many: use exceptions based on SnapcraftError
  * rosdep: add support for multiple dependency types (#1479)
  * errors: use function for exit code (#1491)
  * cli: don't raise from excepthook (#1495)
  * repo: make errors based on SnapcraftError (#1499)
  * project loader: refactor into package (#1504)
  * grammar: move into project_loader (#1500)
  * many: simplify plugin loading (#1507)
  * schema: version should have a max length of 32 (#1508)
  * project_loader: process stage package grammar (#1509)
  * project_loader: support grammar on build-packages (#1511)

  [ Alex T Newman ]
  * windows: add cx_Freeze o...