SMTP port isn't set when no SMTP user is specified

[Alendit-0]

Hello,

Mahara does not set a custom SMTP port in case no SMTP user name is specified.

The fix is trivial: in file lib/user.php move line 762 to 756, so the port is set right after setting the host outside of if-clause.

Cheers,
Dimitri.

[Kristina Hoeppner (kris-hoeppner)]

Thanks for the suggested fix, Dimitry. We'll take a look.

BTW, if you want to submit code changes yourself, you can do so into our code review system. Please see https://wiki.mahara.org/wiki/Developer_Area/Contributing_Code

Cheers
Kristina

[Cecilia Vela Gurovic (ceciliavg)]

smtp library allows to define the port as part of the host using this format: [hostname:port]. If it's done this way, it will not use the port specified 'smtpport' in Mahara configuration. In this case, we don't have any issue.

But in the case the host doesn't include the port, then the 'smtpport' in Mahara configuration is used.

So in the case we have the port not defined in 'smtphosts' but in 'smtpport', and we don't have the 'smtpuser' value set, then the port is ignored by Mahara and it's not what we want. I think the fix proposed here is correct.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8158

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8158
Committed: https://git.mahara.org/mahara/mahara/commit/0630b4c679f0a6a7fd1d1626058cbe320753528c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0630b4c679f0a6a7fd1d1626058cbe320753528c
Author: Dimitri <email address hidden>
Date: Thu Oct 19 12:01:16 2017 +1300

Bug 1713441: set a custom SMTP port in case no SMTP user name is specified

behatnotneeded

Change-Id: Id1a1d1e99d58b9b2c3567ee36eebaeb70c9944e6

[Mahara Bot (dev-mahara)]

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8179

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8179
Committed: https://git.mahara.org/mahara/mahara/commit/5f39e8f06dde94dc1132318fad207323d8877580
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 5f39e8f06dde94dc1132318fad207323d8877580
Author: Dimitri <email address hidden>
Date: Thu Oct 19 12:01:16 2017 +1300

Bug 1713441: set a custom SMTP port in case no SMTP user name is specified

behatnotneeded

Change-Id: Id1a1d1e99d58b9b2c3567ee36eebaeb70c9944e6
(cherry picked from commit 0630b4c679f0a6a7fd1d1626058cbe320753528c)