config-changed hook error

[Chris MacNaughton]

On trusty-mitaka, designate charm had a config-changed hook error, it looks like maybe during tear down?

juju test log: https://pastebin.ubuntu.com/25387558/
charm unit log: https://pastebin.ubuntu.com/25387561/

[Alex Kavanagh (ajkavanagh)]

So the juju log after doing a "juju remove-relation designate designate-bind" is:

2017-08-25 10:50:31 DEBUG dns-backend-relation-departed /usr/lib/python2.7/dist-packages/pkg_resources/__init__.p
y:187: RuntimeWarning: You have iterated over the result of pkg_resources.parse_version. This is a legacy behavio
r which is inconsistent with the new version class introduced in setuptools 8.0. In most cases, conversion to a t
uple is unnecessary. For comparison of versions, sort the Version instances directly. If you have another use cas
e requiring the tuple, please file a bug with the setuptools project describing that need.
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed stacklevel=1,
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.518 30940 ERROR designate.objects.ada
pters.base [designate-manage - - - - -] TypeError creating PoolNameserverList with values None
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.518 30940 ERROR designate.objects.ada
pters.base Traceback (most recent call last):
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.518 30940 ERROR designate.objects.ada
pters.base File "/usr/lib/python2.7/dist-packages/designate/objects/adapters/base.py", line 153, in parse
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.518 30940 ERROR designate.objects.ada
pters.base values, output_object, *args, **kwargs)
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.518 30940 ERROR designate.objects.ada
pters.base File "/usr/lib/python2.7/dist-packages/designate/objects/adapters/base.py", line 261, in _parse_list
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.518 30940 ERROR designate.objects.ada
pters.base for item in values:
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.518 30940 ERROR designate.objects.ada
pters.base TypeError: 'NoneType' object is not iterable
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.518 30940 ERROR designate.objects.ada
pters.base
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.519 30940 CRITICAL designate [designa
te-manage - - - - -] InvalidObject: Provided object is not valid. Got a TypeError with message 'NoneType' object
is not iterable
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.519 30940 ERROR designate Traceback (
most recent call last):
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.519 30940 ERROR designate File "/usr/bin/designate-manage", line 10, in <module>
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.519 30940 ERROR designate sys.exit(main())
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.519 30940 ERROR designate File "/usr/lib/python2.7/dist-packages/designate/cmd/manage.py", line 132, in main
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.519 30940 ERROR designate fn(*fn_args)
2017-08-25 10:50:31 DEBUG dns-backend-relation-departed 2017-08-25 10:50:31.519 30940 ERROR de...

[Alex Kavanagh (ajkavanagh)]

The following review probably fixes the problem as it was also struggling to get through a charm-recheck-full which kept breaking, possibly for the same reason: https://review.openstack.org/#/c/491526/

[Alex Kavanagh (ajkavanagh)]

I don't think the designate-bind charm is affected at all -- it's all down to designate. I'm marking that side of the bug as invalid.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/491526
Committed: https://git.openstack.org/cgit/openstack/charm-designate/commit/?id=1ef3522f86caa1275ba96553dc6d8ffe08a9a99d
Submitter: Jenkins
Branch: master

commit 1ef3522f86caa1275ba96553dc6d8ffe08a9a99d
Author: Alex Kavanagh <email address hidden>
Date: Mon Aug 7 16:46:11 2017 +0100

    Do less work in the update-status hook

    This patchset, along with the corresponding ones in charms.openstack
    and interface-hacluster reduce the amount of work that the charm does
    during an update-status hook. This also fixes the issue where an
    update-status hook triggered activity in the hacluster subordinate due
    to data being set on the interface. There is still work to be done in
    this area, as the configs for the charm are still being written on every
    update-status hook, although this doesn't result in a restart of any of
    the services. This probably requires a re-think of how the
    charm-helpers function runs; patch to charm-helpers coming up soon.

    This also fixes bug 1712973 where the update-pools command with empty
    pools errors causing the charm to error out and fail. This is
    undesirable, so this condition is caught and logged instead.

    Change-Id: I6db68a479dc903ce620ba62c1898247f71d14701
    Depends-On: I3717387d1d8d2ab875d51f262efd1df7f2529689
    Depends-On: I750f3c41a2f0447a47cfd19bab1d4958de4577f2
    Closes-Bug: #1708396
    Closes-Bug: #1712973