[UIFe] Headerbar buttons that are highlighted/coloured in Adwaita are not coloured at all in Ambiance.

Bug #1709500 reported by Sebastien Bacher
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
ubuntu-themes (Ubuntu)
Fix Released
High
Didier Roche-Tolomelli
Artful
Fix Released
High
Didier Roche-Tolomelli

Bug Description

Using Ambiance on artful, the "action buttons" used in GtkHeaderBar are using a color similar to bar background which makes them not stand out. One example is the file-roller extract dialog, when using Adwaita the "extract" button is blue which make it an obvious click target, that's not the case under our themes

Tags: gnome-17.10

Related branches

tags: added: gnome-17.10
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Re: Headerbar buttons that are highlighted/coloured in Adwaita are not coloured at all in Ambiance.

I'm not sure the colouring of some headerbar buttons in some windows is a good design choice by upstream. In the example in the bug description, the (blue in Adwaita) Extract button is no more important than the non-blue Extract button in the dialog that came before it.

So yeah it's a theme bug that Ambiance is missing this highlighting but also not really a noticeable problem unless you're familiar with other themes.

summary: - The headerbar action buttons lack contrast
+ Headerbar buttons that are highlighted/coloured in Adwaita are not
+ coloured at all in Ambiance.
Changed in ubuntu-themes (Ubuntu):
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

The problem is that if you are not familiar with GNOME applications putting button in their titlebar it might be a bit difficult to find those

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yes, I would argue many things are non-obvious and difficult to discover in Gnome. But Unity had some similar problems...

Good news though - We can fix this bug by changing the colour to Ubuntu-style, avoid the garish blue/red colours, and choose something else. Everyone could be satisfied with a well-chosen colour.

tags: added: rls-aa-incoming
Changed in ubuntu-themes (Ubuntu):
importance: Low → High
Will Cooke (willcooke)
tags: removed: rls-aa-incoming
Changed in ubuntu-themes (Ubuntu Artful):
assignee: nobody → Didier Roche (didrocks)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Please find attach one of those actions, see the top green button.

summary: - Headerbar buttons that are highlighted/coloured in Adwaita are not
- coloured at all in Ambiance.
+ [UIFe] Headerbar buttons that are highlighted/coloured in Adwaita are
+ not coloured at all in Ambiance.
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

This is fine from a docs POV. Unfortunately we don't ship any Ubuntu specific screenshots in the 17.10 desktop guide.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-themes - 16.10+17.10.20170929-0ubuntu1

---------------
ubuntu-themes (16.10+17.10.20170929-0ubuntu1) artful; urgency=medium

  * Ambiance/Radiance/*/gtk-widget.css:
    Make primary action button (suggested action) in headerbar more visible
    (LP: #1709500)

 -- Didier Roche <email address hidden> Fri, 29 Sep 2017 09:57:25 -0400

Changed in ubuntu-themes (Ubuntu Artful):
status: Confirmed → Fix Released
Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

I think this caused this regression Bug #1720570.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.