Don't "Clarify selection" if it doesn't matter

[pipe]

When selecting a track that is close to another track, or overlaps (for example in a corner), KiCad opens a small pop-up with a list of tracks so you can select the one you want.

When using the "Copper Connection" or "Trivial Connection", this often does not matter, because all the tracks in the list belong to the same net anyway, so the outcome will be the same.

It would be a nice detail if KiCad knew this, and prevented the necessary step. It should have access to all the information already, so in theory it would just be a simple check to see if all tracks in the list belongs to the same net.

[Jeff Young (jeyjey)]

Patch uploaded for consideration.

[Simon Richter (sjr)]

Building as patch build #29.

Build info: http://darine.hogyros.de:8080/job/windows-kicad-msys2-patch/29/

[Simon Richter (sjr)]

Jeff, the build failed with your patch, I suspect because of the CMakeLists.txt changes.

[Jeff Young (jeyjey)]

Rats; looking at the CMakeLists.txt changes in the patch it looks like I reverted any material changes and all that’s left is cleanup of duplicated includes. So you should be able to remove it from the patch.

> On 9 Jan 2018, at 21:15, Simon Richter <email address hidden> wrote:
>
> Jeff, the build failed with your patch, I suspect because of the
> CMakeLists.txt changes.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1708869
>
> Title:
> Don't "Clarify selection" if it doesn't matter
>
> Status in KiCad:
> In Progress
>
> Bug description:
> When selecting a track that is close to another track, or overlaps
> (for example in a corner), KiCad opens a small pop-up with a list of
> tracks so you can select the one you want.
>
> When using the "Copper Connection" or "Trivial Connection", this often
> does not matter, because all the tracks in the list belong to the same
> net anyway, so the outcome will be the same.
>
> It would be a nice detail if KiCad knew this, and prevented the
> necessary step. It should have access to all the information already,
> so in theory it would just be a simple check to see if all tracks in
> the list belongs to the same net.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1708869/+subscriptions

[Jeff Young (jeyjey)]

Patch without CMakeLists changes. (It's also re-based, although that didn't change anything in the patch other than the reference hash.)

This builds cleanly on my machine (but then the previous one did too).

[Simon Richter (sjr)]

Compiled fine: http://darine.hogyros.de:8080/job/windows-kicad-msys2-patch/32/

1 new warning:

fp_conflict_assignment_selector.cpp:82: unused variable 'item' [-Wunused-variable]

[Kristoffer (kristoffer-odmark)]

Confirmed, patch works after revert of cmakelist changes.

Fixes the disambiguation menu popping up everywhere.

[Jeff Young (jeyjey)]

Hi Tom & Orson,

Did either of you have a chance to look at this yet?

Cheers,
Jeff.

[1] https://bugs.launchpad.net/bugs/1708869 <https://bugs.launchpad.net/bugs/1708869>
[2] http://darine.hogyros.de:8080/job/windows-kicad-msys2-patch/32/ <http://darine.hogyros.de:8080/job/windows-kicad-msys2-patch/32/>
[3] https://launchpadlibrarian.net/353027266/0001-Avoid-selection-disambiguation-menu-when-possible.patch <https://launchpadlibrarian.net/353027266/0001-Avoid-selection-disambiguation-menu-when-possible.patch>

> On 10 Jan 2018, at 17:29, Kristoffer <email address hidden> wrote:
>
> Confirmed, patch works after revert of cmakelist changes.
>
> Fixes the disambiguation menu popping up everywhere.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1708869
>
> Title:
> Don't "Clarify selection" if it doesn't matter
>
> Status in KiCad:
> In Progress
>
> Bug description:
> When selecting a track that is close to another track, or overlaps
> (for example in a corner), KiCad opens a small pop-up with a list of
> tracks so you can select the one you want.
>
> When using the "Copper Connection" or "Trivial Connection", this often
> does not matter, because all the tracks in the list belong to the same
> net anyway, so the outcome will be the same.
>
> It would be a nice detail if KiCad knew this, and prevented the
> necessary step. It should have access to all the information already,
> so in theory it would just be a simple check to see if all tracks in
> the list belongs to the same net.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1708869/+subscriptions

[KiCad Janitor (kicad-janitor)]

Fixed in revision 3f6af59cac75a56828f73fe57ccdc33edb320e25
https://git.launchpad.net/kicad/patch/?id=3f6af59cac75a56828f73fe57ccdc33edb320e25

[Jeff Young (jeyjey)]

For posterity, this patch is the one that was committed. (It contains a drag bug fix over the original.)