budgie-desktop freezes with the global app-menu

Bug #1705653 reported by fossfreedom
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
vala-panel-appmenu (Ubuntu)
Fix Released
Medium
Martin Wimpress 

Bug Description

Artful 17.10 - installed the binary package budgie-panel-appmenu

Launching Excel, checking the global menu appears - then click the budgie start menu. The whole desktop freezes solid.

The solution is to add to the proxy

https://github.com/rilian-la-te/vala-panel-appmenu/commit/ee82d6cbb938f1f5519d29c9dee5c58b4ec42443

so we'll need to add all the blacklist and suggested schema blacklist to the debian package overrides for unity-gtk-modules.

Tags: artful
Changed in vala-panel-appmenu (Ubuntu):
status: New → In Progress
assignee: nobody → fossfreedom (fossfreedom)
tags: added: artful
Revision history for this message
fossfreedom (fossfreedom) wrote :
Revision history for this message
fossfreedom (fossfreedom) wrote :

please find the fix for this - as mentioned in the changelog, this patch has been accepted upstream

(https://github.com/rilian-la-te/vala-project-packages/commit/bf4f2fbfa67476b067abd25b7fbd5835308194e4)

and I've tested this on Ubuntu Budgie 17.10 via our proposed repo

https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/artful-proposed/+sourcepub/8146451/+listing-archive-extra

Revision history for this message
Jeremy Bícha (jbicha) wrote :

The github commit you pointed to already exists in the Ubuntu package, but org.valapanel.appmenu-gtk-module.gschema.xml isn't installed.

That looks like an embedded code copy of unity-gtk-module which isn't allowed according to Debian Policy 4.13, at least as long as unity-gtk-module is still in Ubuntu.

https://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles

I'll let flexiondotorg look into all this more.

Revision history for this message
fossfreedom (fossfreedom) wrote :

Martin - there is a new version of vala-panel-appmenu upstream available.

I've fixed the budgie build issues with this new version and pushed this to vala-project-packages.

Not sure though what you think though about Jeremy's embedded code copy query.

Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

When vala-panel-appmenu was reviewed during packaging it was agree that gschema overrides should be shipped as distro overrides and not part of the package.

Revision history for this message
fossfreedom (fossfreedom) wrote :

Martin - as discussed I've pushed to upstream a distro specific override

 - https://github.com/rilian-la-te/vala-project-packages/commit/7f6c57cd393e467c38b4cd17fbc3fc14752a673a

Changed in vala-panel-appmenu (Ubuntu):
assignee: fossfreedom (fossfreedom) → nobody
Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

Regarding the embedded fork of unity-gtk-module in the upstream project, I'm going to raise that with them. The Ubuntu package uses unity-gtk-module, but I would like to introduce vala-panel-appmenu to Debian and upstream will need to decouple appmenu-gtk-module from vala-panel-appmenu.

Changed in vala-panel-appmenu (Ubuntu):
assignee: nobody → Martin Wimpress (flexiondotorg)
importance: Undecided → Medium
Changed in vala-panel-appmenu (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vala-panel-appmenu - 0.5.3-0ubuntu2

---------------
vala-panel-appmenu (0.5.3-0ubuntu2) artful; urgency=medium

  * Add gschema overrides to add the appropriate unity-gtk-module
    blacklist for Budgie and MATE. (LP: #1705653)

 -- Martin Wimpress <email address hidden> Wed, 30 Aug 2017 11:08:34 +0100

Changed in vala-panel-appmenu (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.