Site pages admin pagination ajax [Error]: Call to undefined method View::get_template_views()

[Mark Webster]

Mahara 16.10.2 (present in .4 too)

Ajax call to /json/viewlist.php when using pagination or results per page dropdown on /admin/site/views.php results in:

error:true
error_class:"SystemException"
error_message:"[Error]: Call to undefined method View::get_template_views()"
error_name:"SystemException"
error_number:0
error_rendered:"A nonrecoverable error occurred. This probably means you have encountered a bug in the system"

[Kristina Hoeppner (kris-hoeppner)]

Mark, are you going to fix this issue?

Not a problem in 17.04 as the methods changed.

Test instructions:

1. Create more than 20 pages in Admin -> Configure site -> Pages.
2. Try changing the paginator to show only 1 result:

Expected result: The call is processed and only one result is displayed per page.
Actual result: The drop-down menu choice doesn't have any effect.

3. Click the paginator to go to a different result page.

Expected result: You see the results on the selected page.
Actual result: Nothing happens.

[Mahara Bot (dev-mahara)]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7986

[Robert Lyon (robertl-9)]

This was caused by commit b73b5e70b94a1afee19a1245a651a5bd020d58c2 where we changed the function name to call from View::get_template_views() to View::get_site_template_views() but forgot to update the json/viewlist.php to use the same function.

[Mahara Bot (dev-mahara)]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7987

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7987
Committed: https://git.mahara.org/mahara/mahara/commit/7e50299ef024445838e19165d4d69366d174408e
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 7e50299ef024445838e19165d4d69366d174408e
Author: Robert Lyon <email address hidden>
Date: Thu Sep 7 09:25:58 2017 +1200

Bug 1703787: Pagination failing for site pages

Due to the json file not using the correct call to site templates

It was updated for the initial page load but not for the json load of
pagination results

behatnotneeded

Change-Id: Icea835bc6252df05aac8b3a6cf367d1f2364f7ea
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7986
Committed: https://git.mahara.org/mahara/mahara/commit/ffc16c222a6b0e58a0131fb9f6bdede1e185b3f0
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit ffc16c222a6b0e58a0131fb9f6bdede1e185b3f0
Author: Robert Lyon <email address hidden>
Date: Thu Sep 7 09:25:58 2017 +1200

Bug 1703787: Pagination failing for site pages

Due to the json file not using the correct call to site templates

It was updated for the initial page load but not for the json load of
pagination results

behatnotneeded

Change-Id: Icea835bc6252df05aac8b3a6cf367d1f2364f7ea
Signed-off-by: Robert Lyon <email address hidden>