"Join this group" points to wrong group

[David Truong]

I'm on version 17.04.2

Have 15+ groups on your mahara.
Have multiple group with their access open.
Get at least two on any page but the first.
Start looking for an open group to join on any page but the first.
If you don't see enough groups, search for "All group".
Click on the first "Join this group" beside a group that is not on the first page.

Normal scenario:
You've joined the group beside which you clicked "Join this group"

Bug (what i get):
You've joined the first open group of the first page or you've been redirected to the first page because there was none on it.

Depending on which "Join this group" you clicked on you've joined the corresponding open one of the first page. If no corresponding open group exist on the first page you've been redirected to the first page. ie: click on the second open group of the second page, you've joined the second open group of the first page if there is a second open group

[Kristina Hoeppner (kris-hoeppner)]

Thank you for the report, David. I could replicate it.

Test scenario:

1. Set up 2 users on your Mahara site.
2. As site admin, set up an open group.
3. Go to Administration -> Groups -> Administer groups and click the "Copy group" button 35 times to quickly create groups or create a CSV file and upload a bunch of open groups.
4. Log in as the second user (as the first one will be an admin in all groups if created via the interface).
5. Navigate to the second result page on "Groups" -> "Find groups".
6. Note the name and URL of the open group that you are planning on joining.
7. Click the "Join this group" button.

Expected result: You joined the selected group.
Actual result: You joined the first open group on the first page of the results.

[Kristina Hoeppner (kris-hoeppner)]

Niranjan confirmed that it's also an issue on 16.04 and 16.10 but only affects the joining of new groups but not the "Request to join this group" button.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/7876

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7876
Committed: https://git.mahara.org/mahara/mahara/commit/aa9ab0cad9b8bac3a47a7d116aaa4be2049b6760
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit aa9ab0cad9b8bac3a47a7d116aaa4be2049b6760
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 17 08:25:23 2017 +1200

Bug 1703680: join group pagination error

In the screen that displays groups we can join
the functions associated with the 'join me' button
are given the correct group number (not the ones from
the first page of the pagination)

behatnotneeded

Change-Id: I1737947acd67258dd49f8c24bb69aacb5402aafc

[Mahara Bot (dev-mahara)]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7903

[Mahara Bot (dev-mahara)]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7904

[Mahara Bot (dev-mahara)]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7905

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7904
Committed: https://git.mahara.org/mahara/mahara/commit/bc985764b8d2f56f4f7c646a8f7539c92c30c46e
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit bc985764b8d2f56f4f7c646a8f7539c92c30c46e
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 17 08:25:23 2017 +1200

Bug 1703680: join group pagination error

In the screen that displays groups we can join
the functions associated with the 'join me' button
are given the correct group number (not the ones from
the first page of the pagination)

behatnotneeded

Change-Id: I1737947acd67258dd49f8c24bb69aacb5402aafc
(cherry picked from commit aa9ab0cad9b8bac3a47a7d116aaa4be2049b6760)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7903
Committed: https://git.mahara.org/mahara/mahara/commit/75fb275b8011aab7c30fa707e944e788fe1b900d
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 75fb275b8011aab7c30fa707e944e788fe1b900d
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 17 08:25:23 2017 +1200

Bug 1703680: join group pagination error

In the screen that displays groups we can join
the functions associated with the 'join me' button
are given the correct group number (not the ones from
the first page of the pagination)

behatnotneeded

Change-Id: I1737947acd67258dd49f8c24bb69aacb5402aafc
(cherry picked from commit aa9ab0cad9b8bac3a47a7d116aaa4be2049b6760)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7905
Committed: https://git.mahara.org/mahara/mahara/commit/fb2ea62f46c83c9c79dba4f07301ce5ff4989d41
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit fb2ea62f46c83c9c79dba4f07301ce5ff4989d41
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 17 08:25:23 2017 +1200

Bug 1703680: join group pagination error

In the screen that displays groups we can join
the functions associated with the 'join me' button
are given the correct group number (not the ones from
the first page of the pagination)

behatnotneeded

Change-Id: I1737947acd67258dd49f8c24bb69aacb5402aafc
(cherry picked from commit aa9ab0cad9b8bac3a47a7d116aaa4be2049b6760)