Merge 4.5.1-2 from Debian Sid

[Simon Quigley]

Attached is a debdiff merging python-tornado 4.5.1-2 from Debian Sid. The maintainer has updated the copyright, and this debdiff also decreases some of the erroneous delta that the most recent Ubuntu upload had in respect to patches.

The debdiff is applicable to 4.5.1-2 from Sid.

[Simon Quigley (tsimonq2)]

I'm subscribing ~ubuntu-sponsors as well as Michael Hudson-Doyle (last uploader to Ubuntu) and Bhavani Shankar (who wrote the tests disabling the tests).

Bhavani, is that patch disabling the tests something we still need to have, or has this been fixed already?

[Simon Quigley (tsimonq2)]

(by "who wrote the tests disabling the tests" I mean "who wrote the patch disabling the tests")

[Simon Quigley (tsimonq2)]

Whoops, forgot to add the "Closes" for this bug in the debdiff.

Here's a new one fixing that.

[Mattia Rizzolo (mapreri)]

This time, I would like to understand *why* there was that switch from mysqldb to pymsql.
Mostly because just looking at the proposed diff it seems to me that it's used only in an example, and it's changing only a Suggets. And both mysqldb and pymsql are in main, so I don't see any clear advantage.

@Corey: you did this change initially, without explaining it (neither in changelog nor in the patch header), and there was no bug closed either, care to explain?.

[Michael Hudson-Doyle (mwhudson)]

Did I just miss that I could have merged from Debian or did the new version only just land there? In any case, I fully support merging :)

[Bhavani Shankar (bhavi)]

Btw, regarding the latest change I had skipped a couple of test cases and added few commits from github to add support for python 3.6.

Now that, its a new upstream version from github can we have a check build without my change just to see how things work out.

[Corey Bryant (corey.bryant)]

Apologies for the lack of changelog explanation. I agree it's not useful and sheds zero light on why this was done.

This all came about for OpenStack. The following evaluation was done by the upstream OpenStack community to narrow down on a single mysql client:

https://wiki.openstack.org/wiki/PyMySQL_evaluation

At the time of that evaluation mysqldb didn't have py3 support and pymysql did. pymysql was pure-python and supported eventlet. So pymysql was deemed the "winning" mysql client that upstream would use.

Historically Ubuntu only supports one client in main. The reason for that is to minimize the number of packages that get LTS/security support provided by Canonical. So with those points in mind, we updated several packages to move from mysqldb to pymysql. We updated all packages that were in main that used python-mysqldb to instead use python-pymysql. The idea was that we would no longer have packages in main that depend on mysqldb, so mysqldb could be moved out of main and into universe.

However, today I'm not sure this is all still needed or not! python-mysqldb and python-pymysql are still both in main and upstream OpenStack still uses both.

[Gianfranco Costamagna (costamagnagianfranco)]

Sigh, can you please rebase it as ubuntu2 version? next time please subscribe me, I did mostly all the merges in the last year, as well, as I tried to upstream the mysqldb change

[Simon Quigley (tsimonq2)]

@LocutusOfBorg What do you mean by "rebase it as ubuntu2 version"? It's not uploaded to the archive yet...

[Gianfranco Costamagna (costamagnagianfranco)]

 python-tornado | 4.5.1-2ubuntu1 | artful/universe | source, amd64, arm64, armhf, i386, ppc64el, s390x

sorry, but I did this merge weeks ago, so please do an upload called 4.5.1-2ubuntu2 if you want, rebased on top of the current artful version

[Simon Quigley (tsimonq2)]

Oh, ok.

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-tornado - 4.5.1-2.1~build1

---------------
python-tornado (4.5.1-2.1~build1) artful; urgency=medium

  [ Simon Quigley ]
  * Upload a no-change rebuild from Debian, to drop
    the Ubuntu delta (LP: #1699426)

 -- Gianfranco Costamagna <email address hidden> Fri, 14 Jul 2017 15:02:22 +0200