Problem with Leap2A import and creating custom layout option for user

Bug #1696587 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
17.04
Fix Released
High
Unassigned
17.10
Fix Released
High
Unassigned

Bug Description

In the view constructor for 17.04+ there is some code that regenerates the view_rows_columns info if missing but that relies on the view id being known.

During the Leap2A import process the view id is not known yet - so we need the constructor to ignore fixing up view_rows_columns data at this point.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7808
Committed: https://git.mahara.org/mahara/mahara/commit/d85a81d05b4575594019eb28d29aea1086a644e4
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit d85a81d05b4575594019eb28d29aea1086a644e4
Author: Robert Lyon <email address hidden>
Date: Tue Jun 6 14:09:24 2017 +1200

Bug 1696587: Only replace the missing view_row_columns records if the view has an id

To avoid problem when creating a view from import when layout is
specified by creating a dummy view to create the layout needed
before the real page is created

behatnotneeded

Change-Id: I9e3fc2e9cb14321b8697ac37890b37191ff2efe1
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7832

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7832
Committed: https://git.mahara.org/mahara/mahara/commit/916b18b1a7b7773bc1d2e00b0d356c2ba6547f62
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 916b18b1a7b7773bc1d2e00b0d356c2ba6547f62
Author: Robert Lyon <email address hidden>
Date: Tue Jun 6 14:09:24 2017 +1200

Bug 1696587: Only replace the missing view_row_columns records if the view has an id

To avoid problem when creating a view from import when layout is
specified by creating a dummy view to create the layout needed
before the real page is created

behatnotneeded

Change-Id: I9e3fc2e9cb14321b8697ac37890b37191ff2efe1
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit d85a81d05b4575594019eb28d29aea1086a644e4)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.