German Documentation file displays incorrect CUPS version

[Ivy Alexander]

The /doc/de/index.html.in file in the package source has an incorrect version number written into a header instead of using '@CUPS_VERSION@' to populate this file as in the other languages' version of the same file, seemingly resulting in /usr/share/cups/doc-root/de/index.html having the wrong version once CUPS is installed:

...
    <div class="body">
      <div class="row">
        <h1>CUPS 2.0.2</h1>
...

instead of:

...
    <div class="body">
      <div class="row">
        <h1>CUPS @CUPS_VERSION@</h1>
...

resulting in 'CUPS 2.0.2' instead of 2.1.3 being shown.

[Till Kamppeter (till-kamppeter)]

Reported upstream as

https://github.com/apple/cups/issues/5019

[Eric Desrochers (slashd)]

* Upstream project :

commit 88d45155d6deb71e0ed2203d9bb1eb63a17d3abf
Author: jschwender <email address hidden>
Date: Sat Apr 23 11:29:15 2016 +0200

    version was hardcoded

diff --git a/doc/de/index.html.in b/doc/de/index.html.in
index c37edd8..307bb69 100644a
--- a/doc/de/index.html.in
+++ b/doc/de/index.html.in
@@ -23,7 +23,7 @@
     </div>
     <div class="body">
       <div class="row">
- <h1>CUPS 2.0.2</h1>
+ <h1>CUPS @CUPS_VERSION@</h1>
        <p>CUPS basiert auf Standards, Open Source Drucksystem entwickelt durch <a href="http://www.apple.com/">Apple Inc.</a> für OS X^&reg; und andere UNIX^&reg;-artige Betriebssysteme.</p>
       </div>
       <div class="row">

* Correction has also landed in Debian "sid" (unstable)

* Ubuntu

It seems like Xenial is the only one affected :

t/cups-1.7.2/doc/de/index.html.in:32: <H1>CUPS @CUPS_VERSION@</H1>
x/cups-2.1.3/doc/de/index.html.in:26: <h1>CUPS 2.0.2</h1>
y/cups-2.2.0/doc/de/index.html.in:26: <h1>CUPS @CUPS_VERSION@</h1>
z/cups-2.2.2/doc/de/index.html.in:26: <h1>CUPS @CUPS_VERSION@</h1>

- Eric

[Eric Desrochers (slashd)]

From previous experience in the same situation, *normally*, a typo like this are worth SRU'ing to stable release when it is bundled with other fixes (non-typo related).

I'm afraid SRU'ing only this particular change won't make (SRU approval) it to -updates.

Ivy, if you can find another cups bug to fix and merge the two in one SRU, I think you'll have better chance to get the SRU approval.

Unless you can actually show that not fixing this particular bug has a significant impact.

- Eric

[Eric Desrochers (slashd)]

Upstream commit url :

https://github.com/apple/cups/commit/88d45155d6deb71e0ed2203d9bb1eb63a17d3abf

[Ivy Alexander (ivyalexander)]

Patch with the fix.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "lp1695876_xenial.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Eric Desrochers (slashd)]

# Sponsor review :

Hi Ivy,

1) The patch doesn't apply cleanly via quilt:

Applying patch fix-typo-in-doc-de.patch
patching file doc/de/index.html.in
Hunk #1 FAILED at 23.
1 out of 1 hunk FAILED -- rejects in file doc/de/index.html.in
Patch fix-typo-in-doc-de.patch does not apply (enforce with -f)

2) d/changelog

Replace from : LP: #1695876 to (LP: #1695876)
Look previous d/changelog section to see example.

Note : A typo like this are worth SRU'ing to stable release when it is bundled with other fixes (non-typo related), so I don't think we can SRU this patch only, unless you can determine that this is causing a bug in the Ubuntu package.

- Eric

[Eric Desrochers (slashd)]

# Sponsor review :

Additionally ...

3) A quilt header in DEP3 format is missing in "fix-typo-in-doc-de.patch"

http://dep.debian.net/deps/dep3/

- Eric

[Eric Desrochers (slashd)]

4) - Don't forget to file the SRU justification tmpl.

https://wiki.ubuntu.com/StableReleaseUpdates
3.1. SRU Bug Template

- Eric

[Simon Quigley (tsimonq2)]

Unsubscribing ~ubuntu-sponsors as there isn't an updated patch yet.