Switch Azure detection to use chassis_asset_tag
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
cloud-init |
Fix Released
|
Medium
|
Chad Smith | ||
cloud-init (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Xenial |
Fix Released
|
Medium
|
Unassigned | ||
Yakkety |
Won't Fix
|
Medium
|
Unassigned | ||
Zesty |
Fix Released
|
Medium
|
Unassigned |
Bug Description
=== Begin SRU Template ===
[Impact]
Azure identifies itself to guests by setting a well known value in the chassis asset field of dmi data. This is done both in Azure public cloud and in Azure Stack (the on-premise variant of Azure).
By checking for this value cloud-init can more quickly identify whether or not it is running on Azure.
[Test Case]
- Launch an instance, enable proposed, upgrade.
- Clean instance and re-boot
$ rm -Rf /var/lib/cloud /var/log/
$ rm -f /etc/cloud/
$ reboot
- ssh back in look around
- confirm 'WARN' does not appear in /var/log/
- look in /run/cloud-
Found single datasource: Azure
- reboot, ssh back in and verify all still good.
[Regression Potential]
Instances running in Azure or Azure Stack that did *not* have this value
would not be identified as Azure. We have been told by representatives
from Microsoft that that will not be the case.
[Other Info]
Upstream commit at
https:/
=== End SRU Template ===
I've got confirmation that the chassis_asset_tag DMI value is a hard-coded identifier for the Azure platform (both Azure and Azure Stack (the on-premise variant of Azure)).
$ cat /sys/class/
7783-7084-
The detection logic in both ds-identify and Azure ds should be updated to use this value.
Related branches
- Joshua Powers (community): Approve
- Server Team CI bot: Needs Fixing (continuous-integration)
- Ryan Harper: Approve
-
Diff: 2029 lines (+1979/-2)7 files modifieddebian/changelog (+12/-2)
debian/patches/cpick-003c6678-net-remove-systemd-link-file-writing-from-eni-renderer (+95/-0)
debian/patches/cpick-11121fe4-systemd-make-cloud-final.service-run-before-apt-daily (+33/-0)
debian/patches/cpick-1cd4323b-azure-remove-accidental-duplicate-line-in-merge (+22/-0)
debian/patches/cpick-5fb49bac-azure-identify-platform-by-well-known-value-in-chassis (+338/-0)
debian/patches/cpick-ebc9ecbc-Azure-Add-network-config-Refactor-net-layer-to-handle (+1474/-0)
debian/patches/series (+5/-0)
Changed in cloud-init: | |
assignee: | nobody → Chad Smith (chad.smith) |
Changed in cloud-init (Ubuntu): | |
status: | New → Fix Released |
importance: | Undecided → Medium |
Changed in cloud-init (Ubuntu Xenial): | |
status: | New → Confirmed |
Changed in cloud-init (Ubuntu Yakkety): | |
status: | New → Confirmed |
Changed in cloud-init (Ubuntu Zesty): | |
status: | New → Confirmed |
Changed in cloud-init (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Changed in cloud-init (Ubuntu Yakkety): | |
importance: | Undecided → Medium |
Changed in cloud-init (Ubuntu Zesty): | |
importance: | Undecided → Medium |
description: | updated |
description: | updated |
tags: | removed: verification-done |
Changed in cloud-init: | |
status: | Confirmed → Fix Committed |
Changed in cloud-init (Ubuntu Yakkety): | |
status: | Fix Committed → Won't Fix |
Paul,
Hi and thanks.
Are you saying that that constant will be in chassis asset in all instances?
If so, thats great.