Hardcoded paths in many support scripts
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Unassigned | ||
3.0 |
Fix Released
|
Low
|
Unassigned |
Bug Description
In 2.12 and master, "/openils/
clear_expired_
generate_
hold_copy_
purge_at_
purge_circulati
purge_holds.srfsh
purge_pending_
update_
There is an established convention for avoiding hardcoded paths here: use "BINDIR/srfsh" instead, and ensure that the correct path is inserted via sed in Open-ILS/
In addition, "/openils/
rollover_
set_pbx_holidays.pl
Other Perl support scripts use a relative path for oils_header.pl. We could follow that convention for these two scripts, or allow the user to optionally specify an alternate path when invoking the script, or insert the correct path during build; I'm not sure which option is preferable.
(See also bug 1255184 and bug 1662297.)
Changed in evergreen: | |
milestone: | 2.12.3 → 2.12.4 |
Changed in evergreen: | |
milestone: | 2.12.4 → 2.12.5 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Working branch user/jeffdavis/ lp1693851- support- scripts- hardcoded- paths contains two commits:
(1) A fix for the srfsh scripts, using BINDIR and substituting the correct path during build: git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=commitdif f;h=c13436b0
http://
(2) A fix for the Perl scripts, using a relative path for oils_header.pl: git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=commitdif f;h=f265cb1c
http://