Reduce hardcoded paths in Evergreen code

Bug #1255184 reported by Dan Scott
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

* Evergreen current master
* OpenSRF current master

There are still some paths that are hardcoded into scripts and libraries in Evergreen. This means that a number of additional steps are required if a user simply wants to go with "./configure; make; make install" as with most other software. If we move to that prefix-free approach in the future, then that will also simplify our documentation.

In any case, in the grammatically-challenged branch user/dbs/less_hardcoded_paths at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/less_hardcoded_paths I have pushed a change that adds a variable for OSRFTranslatorConfig to the eg_vhost.conf sample, as well as fixes for a few scripts that currently have hardcoded paths.

Tags: pullrequest
Dan Scott (denials)
Changed in evergreen:
milestone: none → 2.6.0-alpha1
tags: added: pullrequest
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.6.0-alpha1 → 2.6.0-beta1
Revision history for this message
Ben Shum (bshum) wrote :

Hmm, when I tried to run this just now, on the make install step, it died out with...

/usr/bin/install: will not overwrite just-created `/openils/bin/action_trigger_runner.pl' with `./support-scripts/action_trigger_runner.pl'
/usr/bin/install: will not overwrite just-created `/openils/bin/offline-blocked-list.pl' with `./support-scripts/offline-blocked-list.pl'

Will take a closer look later this upcoming week.

Revision history for this message
Dan Scott (denials) wrote :

Rebased on current master and added a commit that prevents the makefile from trying to install the generated files twice. (Feel free to squash them down, I just wanted to show the change.)

Tested on both Fedora 20 and Ubuntu 12.04 with and without --prefix in the ./configure step... and works.

Revision history for this message
Ben Shum (bshum) wrote :

Works for me too on Ubuntu. Squashed commit as requested and pushed out to master.

Thanks Dan!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.