[Impact]
* Users installing fresh on Zesty or later will lack the
/etc/default/qemu-kvm file to control the convenience features of the
qemu-kvm init script. They have to "guess" what to set in there if they
want to use it.
[Test Case]
* installing qemu-system-common should place the default config file
/etc/default/qemu-kvm
[Regression Potential]
* Overall I'd consider the regression potential of the fix low because of
the very narrow window where it has a "direct" effect other than
providing the base file to be modified by the user if needed (which is
what it should do). The reasons that this window is so narrow is as
such:
- Users who upgraded from anything before qemu 2.8 as in zesty still
have the old (equal content) conffile around - they are not affected
by the issue nor by the fix.
- Users who installed fresh on Zesty or later miss the conffile, but
these days the qemu-kvm script is opt-in as the defaults are good. So
adding the missing conffile for those won't change it either
- Those who really needed the features of the qemu-kvm init script
these days enabled the service AND wrote some sort of config. Those
will get a normal conffile prompt on upgrade and be fine.
- So only those that enabled the service, but did not place a config
file will see a change at all. And then since most in that config
file is defaulting to do nothing the only changing thing even for
them is that KSM is enabled if you are on Bare Metal.
* While the change seems rather safe I still pushed it through migration
and upgrade tests and it didn't raise a flag there.
[Other Info]
* n/a
---
While clearing out the sysv and upstart bits this got inadvertently dropped as well.
The reason it wasn't realized for so long is that:
a) it is a conffile which was not autoremoved on upgrade, so any upgrade continued to work correctly with the old file
b) it is an optional file not needed to be modified for most common use cases, the scripts are hardened against the file being missing so they work
Yet if someone "wants" to use one of the features in those files AND is on a new zesty/artful install the file will be missing.
Fortunately we can add that without too much extra conffile care.
If on a system the file is around already it will be considered as a usual conffile on upgrade (and content didn't change) and if a system never had the file it will deploy its default content.
Given the change that was to be assumed, but all tests look good so far.
Pushing to Artful now and prepping for Zesty then.