Popularity parameter for in-house use

Bug #1688096 reported by Kathy Lussier
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

This suggestion came up during the EG17 conference session on popularity badges.

It would be useful to have a popularity parameter based on in-house use.

Tags: pullrequest
Kathy Lussier (klussier)
Changed in evergreen:
assignee: nobody → Kathy Lussier (klussier)
status: New → In Progress
Revision history for this message
Kathy Lussier (klussier) wrote :

Working branch is available at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1688096-in-house-use-badge

Adding a note that it might appear as if I skipped an id for the new popularity parameter, but I had already grabbed id 17 for bug 1688099. I just want to spend more time looking at the other bug before adding a pullrequest tag to it.

Changed in evergreen:
assignee: Kathy Lussier (klussier) → nobody
status: In Progress → Triaged
tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Mike Rylander (mrylander)
Revision history for this message
Kathy Lussier (klussier) wrote :

I have combined this code with the code from bug 1688099 to add a parameter based on the most number of org units that own a title. Both commits are ready for testing in a new working branch at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1688096-new-popularity-parameters

I'll mark the other bug as a duplicate.

Revision history for this message
Mike Rylander (mrylander) wrote :

Committed to master. Thanks, Kathy!

Note, in consultation with Kathy, I modified the org-count parameter function to consistently find and count copies by circ lib. Because this parameter is about counting copies on the shelves of libraries, this makes more sense than filtering by owing library.

Changed in evergreen:
status: Triaged → Fix Committed
assignee: Mike Rylander (mrylander) → nobody
Revision history for this message
Jason Etheridge (phasefx) wrote :

Hey guys, I think this error came from here this commit:

psql:950.data.seed-values.sql:5253: ERROR: relation "rating.badge" does not exist
LINE 1: INSERT INTO rating.badge (name, description, scope, weight, ...
                    ^

Revision history for this message
Jason Etheridge (phasefx) wrote :

semicolon instead of comma in 220.schema.rating.sql line 82; I'm going to try to fix all of this

Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Revision history for this message
Jason Etheridge (phasefx) wrote :

and missing line from a stored procedure

Revision history for this message
Jason Etheridge (phasefx) wrote :

fixed in master!

Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.