Social media: Extra field shouldn't be shown unless for "Other"

Bug #1687356 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
17.04
Fix Released
Medium
Unassigned
17.10
Fix Released
Medium
Robert Lyon

Bug Description

Mahara 17.04 (no problem in 16.10):

When you are in Main menu -> Content-> Profile -> Social media, the default option is "Other" and a field is displayed right next to it where you can provide the name of the social network.

This field stays open even when an actual option is selected whereas it should disappear as you don't need to provide a name for the network since that'll be selected automatically from your choice (see screenshot).

Tags: regression
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7726

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7727

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7727
Committed: https://git.mahara.org/mahara/mahara/commit/c582059ab224688a7bfcc83840b157d22855cec5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c582059ab224688a7bfcc83840b157d22855cec5
Author: Robert Lyon <email address hidden>
Date: Mon May 8 10:11:58 2017 +1200

Bug 1687356: Fixing up js to work correctly with jQuery

behatnotneeded

Change-Id: I9879485afcbdad483e9f09c3d0250caad35c7c07
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7734

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7734
Committed: https://git.mahara.org/mahara/mahara/commit/e8b9d6bdd7e19a23753bf5669891a1c7821c54fa
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit e8b9d6bdd7e19a23753bf5669891a1c7821c54fa
Author: Robert Lyon <email address hidden>
Date: Mon May 8 10:11:58 2017 +1200

Bug 1687356: Fixing up js to work correctly with jQuery

behatnotneeded

Change-Id: I9879485afcbdad483e9f09c3d0250caad35c7c07
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c582059ab224688a7bfcc83840b157d22855cec5)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.