Mahara

Refactor pages and collection template and styles

Bug #1686259 reported by Pat
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 17.10.0
17.04
Fix Released
Medium
Unassigned
Mahara 17.04.1
17.10
Fix Released
Medium
Unassigned
Mahara 17.10.0

Bug Description

- Unnecessary condition for adding extra classes
- Inconsistent mark ups and classes for similar elements
- Styles for feature is spread out

See original description
Pat (pat-kira)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7671
Committed: https://git.mahara.org/mahara/mahara/commit/c9cee4153d9d79ab399b6332ed7f5e4e2d3d3830
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c9cee4153d9d79ab399b6332ed7f5e4e2d3d3830
Author: Pat Kira <email address hidden>
Date: Fri Apr 21 18:59:03 2017 +1200

Bug 1686259 Refactor pages and collection template and styles

- For both raw and old raw
- Remove extra conditions for adding class
- Remove unused css selectors
- Rename classes for clarity
- Move styles to one file; _panel-quarter.scss
- Consolidate elements and class for maintainability

behatnotneeded

Change-Id: I1e499e697013a16fcfac2b9a73772944619680a4

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7699

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7699
Committed: https://git.mahara.org/mahara/mahara/commit/3f77e19a68eec2d001942d98163c96437b024243
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 3f77e19a68eec2d001942d98163c96437b024243
Author: Pat Kira <email address hidden>
Date: Fri Apr 21 18:59:03 2017 +1200

Bug 1686259 Refactor pages and collection template and styles

- For both raw and old raw
- Remove extra conditions for adding class
- Remove unused css selectors
- Rename classes for clarity
- Move styles to one file; _panel-quarter.scss
- Consolidate elements and class for maintainability

behatnotneeded

Change-Id: I1e499e697013a16fcfac2b9a73772944619680a4
(cherry picked from commit c9cee4153d9d79ab399b6332ed7f5e4e2d3d3830)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.