SRU: resolve GTK+3.22 regressions in budgie-desktop

[fossfreedom]

[Impact]
Upstream has released v10.3 of budgie-desktop.

The main aim of the release was to resolve a number of GTK+3.22 regressions together with additional functionality.

Zesty is currently v10.2.9

This SRU request is to cherry-pick the key GTK+3.22 regressions from this upstream release and apply this to zesty

[Test Case]
With the current version: Move the panel to the bottom. Click the start menu button. Note that the start menu button jumps from the top of the screen to the bottom
With the updated version: Click on the start menu button and the popup should not jump from top-to-bottom

With the current version: Click any of the panel applets. Note the speed of opening of the popup. It is instant.
With the new version: Click of any panel applets, the popup animation should be exactly the same as now i.e. instant with no flickering.

With the current version: clear the notifications so that he bell symbol in the panel is white. Reboot. The bell symbol will turn red due to connecting of network manager to your wifi.
With the new version: repeat - network manager notifications do not cause the bell symbol to turn red.

With the current version: Press ALT+F2. Note that the popup dialog is very small and does not display all the information about applications when you search.
With the new version: Press ALT+F2. The popup dialog correctly displays all information about the applications found when searching

[Regression Potential]
For the majority of setups the bottom panel menu popups are resolved. Note - the bottom panel popups that drop quickly from top-to-bottom may not be resolved in all setups - this is a known upstream issue tracked here. https://github.com/budgie-desktop/budgie-desktop/issues/867

Since we have redone the disable popover animation patch there is no
chance of regression that the double popups animation will return.

There is no regression potential for the notification issue on first logon given that the current capability is broken.

There is no regression potential for the ALT+F2 given that the current capability is broken.

[Bhavani Shankar (bhavi)]

Looking into this.

[Launchpad Janitor (janitor)]

This bug was fixed in the package budgie-desktop - 10.2.9-3ubuntu5

---------------
budgie-desktop (10.2.9-3ubuntu5) artful; urgency=medium

  * Cherry-pick bug-fix release (LP: #1685447)
    + 0004-Add-network-manager-to-the-spamlist-for-notification.patch
      Stop spamming notification icon on first logon
    + 0005-panel-Fix-troublesome-popovers-once-and-for-all.patch
      GTK+3.22 regression fix for bottom panel menu applet popup
      (LP: #1661159)
      GTK+3.22 regression fix to restore popover animations
    + 0006-rundialog-Fix-stumpy-rundialog-syndrome-issue-800.patch
      GTK+3.22 regression fix to correctly size the run-dialog
    + disable-popover-animations.patch
      reverse part of patch 0005 since testing has revealed double
      animation effects are still visible for some setups

 -- David Mohammed <email address hidden> Sun, 16 Apr 2017 22:21:53 +0100

[Bhavani Shankar (bhavi)]

Uploaded to zesty. Waiting in approval queue

@ubuntu-sru-team: Kindly request you to approve the same.

budgie-desktop (10.2.9-3ubuntu4.1) zesty; urgency=medium

  * Cherry-pick bug-fix release (LP: #1685447)
    + 0004-Add-network-manager-to-the-spamlist-for-notification.patch
      Stop spamming notification icon on first logon
    + 0005-panel-Fix-troublesome-popovers-once-and-for-all.patch
      GTK+3.22 regression fix for bottom panel menu applet popup
      (LP: #1661159)
      GTK+3.22 regression fix to restore popover animations
    + 0006-rundialog-Fix-stumpy-rundialog-syndrome-issue-800.patch
      GTK+3.22 regression fix to correctly size the run-dialog
    + disable-popover-animations.patch
      reverse part of patch 0005 since testing has revealed double
      animation effects are still visible for some setups

Date: Sun, 16 Apr 2017 22:21:53 +0100
Changed-By: David Mohammed <email address hidden>
Signed-By: Bhavani Shankar <email address hidden>
https://launchpad.net/ubuntu/+source/budgie-desktop/10.2.9-3ubuntu4.1

==

 OK: budgie-desktop_10.2.9.orig.tar.xz
 OK: budgie-desktop_10.2.9-3ubuntu4.1.debian.tar.xz
 OK: budgie-desktop_10.2.9-3ubuntu4.1.dsc
     -> Component: universe Section: misc

Upload Warnings:
Redirecting ubuntu zesty to ubuntu zesty-proposed.
This upload awaits approval by a distro manager

Announcing to <email address hidden>

Thank you for your contribution to Ubuntu.

Unsubscribing sponsors for now.

Thanks!

[Łukasz Zemczak (sil2100)]

I generally don't like SRUs that have one SRU bug for many fixes. Usually this rises a red flag.

That being said, this time I'll review it as is since actually each fix has a test case written here. The regression potential section could use some additional love though. Remember that the whole sense of that section is to give us an idea what could, completely theoretically, get broken by touching the selected pieces of code. So, even though something can have 'no regression potential', try thinking about what could have been broken accidentally by this change in the worst case scenario.
That would make the review much easier.

But before approving the upload (in case all goes well during the review) I'll re-upload it with a modified changelog entry as there is an LP bug mentioned that's invalidly taken into the SRU consideration. So there will be a reject followed by a new approval.

[Łukasz Zemczak (sil2100)]

Hello fossfreedom, or anyone else affected,

Accepted budgie-desktop into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/budgie-desktop/10.2.9-3ubuntu4.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[fossfreedom (fossfreedom)]

Tested the test conditions after enabling proposed.

Note - checked that I installed all the binary packages for budgie-desktop followed by a reboot and login

sudo apt install budgie-core budgie-desktop gir1.2-budgie-desktop-1.0 libbudgie-plugin0 libbudgietheme0 libraven0

All the test conditions passed - thus happy this SRU has been resolved.

[Launchpad Janitor (janitor)]

This bug was fixed in the package budgie-desktop - 10.2.9-3ubuntu4.1

---------------
budgie-desktop (10.2.9-3ubuntu4.1) zesty; urgency=medium

  * Cherry-pick bug-fix release (LP: #1685447)
    + 0004-Add-network-manager-to-the-spamlist-for-notification.patch
      Stop spamming notification icon on first logon
    + 0005-panel-Fix-troublesome-popovers-once-and-for-all.patch
      GTK+3.22 regression fix for bottom panel menu applet popup
      (LP:1661159)
      GTK+3.22 regression fix to restore popover animations
    + 0006-rundialog-Fix-stumpy-rundialog-syndrome-issue-800.patch
      GTK+3.22 regression fix to correctly size the run-dialog
    + disable-popover-animations.patch
      reverse part of patch 0005 since testing has revealed double
      animation effects are still visible for some setups

 -- David Mohammed <email address hidden> Sun, 16 Apr 2017 22:21:53 +0100

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for budgie-desktop has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.