Footer headings are showing up twice

[Rebecca Blundell]

When clicking on T&C, Privacy and About in the footer, the heading shows up twice. It's not a problem for Contact Us though. Example screenshot attached

[Kristina Hoeppner (kris-hoeppner)]

Robert had fixed a bunch of those up in the past and these three pages must have been missed. Should be an easy fix.

[Robert Lyon (robertl-9)]

Ok the issue here is that the PHP page sets the heading, eg

define('TITLE', get_string('privacystatement'));

But also the 'static' page content (that can be edited in Admin -> Static pages) also sets the heading as part of the content.

I'm guessing that the one in static content should not be there for newly installed sites.
Existing sites can always edit their static pages content to fix up.

I'll alter the default content that is installed to not include the editable title for those pages.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/7729

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7729
Committed: https://git.mahara.org/mahara/mahara/commit/efc7dc038bbae275edd8d77a658220877d92e380
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit efc7dc038bbae275edd8d77a658220877d92e380
Author: Robert Lyon <email address hidden>
Date: Mon May 8 11:27:02 2017 +1200

Bug 1683551: Remove duplicate headings for About / T&C / Privacy pages

This patch is only for newly installed sites ONLY
- existing sites will need to edit via Admin -> Static pages

behatnotneeded

Change-Id: I44495c985bce200656d1b80c6458331d888bc666
Signed-off-by: Robert Lyon <email address hidden>

[Robert Lyon (robertl-9)]

Ok this is fixed for NEW SITES only.

Existing sites can be fixed via the admin interface for static pages

[Mahara Bot (dev-mahara)]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7733

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7733
Committed: https://git.mahara.org/mahara/mahara/commit/58e94bf6b926cb366b1a2194e2989a7e2e181d7f
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 58e94bf6b926cb366b1a2194e2989a7e2e181d7f
Author: Robert Lyon <email address hidden>
Date: Mon May 8 11:27:02 2017 +1200

Bug 1683551: Remove duplicate headings for About / T&C / Privacy pages

This patch is only for newly installed sites ONLY
- existing sites will need to edit via Admin -> Static pages

behatnotneeded

Change-Id: I44495c985bce200656d1b80c6458331d888bc666
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit efc7dc038bbae275edd8d77a658220877d92e380)