DigitalOcean network improvements
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
cloud-init |
Fix Released
|
Medium
|
Unassigned | ||
cloud-init (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Xenial |
Fix Released
|
Medium
|
Unassigned | ||
Yakkety |
Fix Released
|
Medium
|
Unassigned | ||
Zesty |
Fix Released
|
Medium
|
Unassigned | ||
Artful |
Fix Released
|
Medium
|
Unassigned |
Bug Description
[Impact]
Due to the new rendering of /etc/network/
With out this update, users upgrading on DigitalOcean will not get DNS resolution.
[Regression Potential]
Low. This change is scope to DigitalOcean only. DigitalOcean has tested this Datasource exhaustively.
[TEST Cases]
- provision on DigitalOcean without a private IP
- provision on DigitalOcean with a private IP
- provision on DigitalOCean with IPV6 and private IP
- provision on DigitalOcean with IPV6
In all cases, interfaces should be configured and DNS resolution should work.
[ORIGINAL REPORT]
This is a request to merge the improvements to the linked PR that improves the DigitalOcean datasource.
The changes:
- No longer bind the nameservers to a specific interface to bring it inline with the other DataSources like OpenStack and SmartOS.
- Fix mis-binding the IPV4all address to a secondary interface by considering 'eth0' or 'ens3' first
- Consider all network definitions, not just 'public' or 'private'.
Related branches
- Server Team CI bot: Needs Fixing (continuous-integration)
- cloud-init Commiters: Pending requested
-
Diff: 26 lines (+10/-4)1 file modifiedcloudinit/sources/helpers/digitalocean.py (+10/-4)
- Scott Moser: Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 135 lines (+34/-30)2 files modifiedcloudinit/sources/helpers/digitalocean.py (+7/-11)
tests/unittests/test_datasource/test_digitalocean.py (+27/-19)
Changed in cloud-init (Ubuntu): | |
status: | New → Fix Released |
Changed in cloud-init (Ubuntu): | |
status: | Fix Released → Fix Committed |
Changed in cloud-init (Ubuntu): | |
status: | Fix Committed → Fix Released |
Changed in cloud-init (Ubuntu Xenial): | |
status: | New → Confirmed |
Changed in cloud-init (Ubuntu Yakkety): | |
status: | New → Confirmed |
Changed in cloud-init (Ubuntu Zesty): | |
status: | New → Confirmed |
Changed in cloud-init (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Changed in cloud-init (Ubuntu Yakkety): | |
importance: | Undecided → Medium |
Changed in cloud-init (Ubuntu Zesty): | |
importance: | Undecided → Medium |
Changed in cloud-init (Ubuntu Artful): | |
importance: | Undecided → Medium |
Changed in cloud-init: | |
importance: | Undecided → Medium |
description: | updated |
description: | updated |
tags: |
added: verification-done-xenial removed: verification-done |
tags: | added: verification-needed-yakkety verification-needed-zesty |
tags: |
added: verification-doner removed: verification-done-xenial verification-needed-yakkety verification-needed-zesty |
tags: |
added: verification-done removed: verification-doner |
tags: | added: yakkety-verification-done zesty-verification-done |
tags: |
added: verification-done-xenial verification-done-yakkety verification-done-zesty removed: verification-done yakkety-verification-done zesty-verification-done |
Commits have landed, calling this fix released.