[GTK+3 build] Sticky Notes - Can't select text in note

[philthynz]

[Impact]

It's not possible to select the text in sticky notes in mate-applets 1.18.x. Attempting to do it just grabs the sticky note window to move it.

The fix for this issue is provided in the debdiffs attached to the report.

Would be nice to have the fix backported to Zesty and Artful, as the issue causes problems for users who use sticky notes daily.

[Test Case]

Steps to reproduce:

- double-click on stickynotes applet icon to create a new sticky note
- type any text into the sticky note window
- try to select the text with the mouse

Instead of selecting the text, the sticky note window will be grabbed to move it, with mouse pointer changing accordingly.

[Regression Potential]

The fix only affects stickynotes applet and can't affect any other parts of the desktop. Besides, the fix had been tested by upstream developers.

The only regression that could be introduced by the fix is the inability to grab and move the sticky note window at all. However, it can still be grabbed by the top part of the window, as before. It worked that way in older versions (in GTK+2 builds), so it's what the users would expect.

[Original Description]

Ubuntu 16.04, Ubuntu 17.04

I upgraded to Mate Desktop 1.18 from ppa https://launchpad.net/~jonathonf/+archive/ubuntu/mate-1.18. And i tested this in 17.04 Ubuntu Mate. Same issue...

The sticky notes text can't be selected. The mouse pointer just grabs the note instead of selecting any text.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Vlad Orlov (monsta)]

Looks like we have an upstream issue here, since it's confirmed in other distros as well.

For reference, I'll post the link to your upstream report:
https://github.com/mate-desktop/mate-applets/issues/236

[Vlad Orlov (monsta)]

Also affects mate-applets 1.16 in Ubuntu 16.10 (due to GTK+3 build used there).

[Oliver Joos (oliver-joos)]

This bug has been fixed in Gnome, see https://launchpad.net/bugs/1703110

[Oliver Joos (oliver-joos)]

... and it already has been reported to the MATE team, see https://github.com/mate-desktop/mate-applets/issues/236

[Oliver Joos (oliver-joos)]

@muktupavels: thank you for finding the corresponding commit!

See https://bugs.launchpad.net/ubuntu/zesty/+source/gnome-applets/+bug/1703110/comments/4

[Alberts Muktupāvels (muktupavels)]

Finding commit? I found problem and fixed it in gnome-applets... :P

[Oliver Joos (oliver-joos)]

Oh, I see! So all beer goes to you! ;-)

[Alberts Muktupāvels (muktupavels)]

Someone needs to test it with mate-applets, I don't know if that fixes problem in mate-applets. I tested only with gnome-applets...

[Oliver Joos (oliver-joos)]

I just rebuilt mate-applets 1.18.1 on a Linux Mint 18.2 MATE (Live DVD) together with your patch.
The patch fixes this bug! Selecting text by mouse works again as expected.

Here is the patch I applied:
https://git.gnome.org/browse/gnome-applets/commit/?h=gnome-3-22&id=ac310d6a362db0ddb55ab9bc581a9c92a1c1fed0

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Debdiff with the fix for Zesty" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Simon Quigley (tsimonq2)]

Hey Vlad!

Could you please feel out the bug to follow the SRU template? I (or someone else) can upload it for you then.

Thanks!

[Vlad Orlov (monsta)]

Sure, I can add it, I just thought the fix should go into Artful first...

Also maybe Martin would like to do it himself and then upload the package?

[Vlad Orlov (monsta)]

Ok, I guess I'll have to do it myself, now that Artful is released w/o the patch...

[Vlad Orlov (monsta)]

[Impact]

It's not possible to select the text in sticky notes
in mate-applets 1.18.x. Attempting to do it just
grabs the sticky note window to move it.

The fix for this issue is provided in the debdiffs
attached to the report.

Would be nice to have the fix backported to Zesty and
Artful, as the issue causes problems for users who
use sticky notes daily.

[Test Case]

Steps to reproduce:

- double-click on stickynotes applet icon to create
  a new sticky note
- type any text into the sticky note window
- try to select the text with the mouse

Instead of selecting the text, the sticky note window
will be grabbed to move it, with mouse pointer changing
accordingly.

[Regression Potential]

The fix only affects stickynotes applet and can't affect
any other parts of the desktop. Besides, the fix had been
tested by upstream developers.

The only regression that could be introduced by the fix
is the inability to grab and move the sticky note window
at all. However, it can still be grabbed by the top part
of the window, as before. It worked that way in older
versions (in GTK+2 builds), so it's what the users would
expect.

[Simon Quigley (tsimonq2)]

Uploaded.

[Launchpad Janitor (janitor)]

This bug was fixed in the package mate-applets - 1.18.1-3ubuntu1

---------------
mate-applets (1.18.1-3ubuntu1) bionic; urgency=medium

  * fix-stickynotes-selection.patch: new patch by Alberts
    Muktupāvels. Fixes text selection in the notes in
    stickynotes applet. (LP: #1675581)

 -- Vlad Orlov <email address hidden> Sun, 29 Oct 2017 12:23:53 +0300

[Vlad Orlov (monsta)]

This can go into Zesty as well, but the entry for Zesty is missing...

[Simon Quigley (tsimonq2)]

Apologies, uploaded.

[Vlad Orlov (monsta)]

Thanks :)

[Brian Murray (brian-murray)]

Hello philthynz, or anyone else affected,

Accepted mate-applets into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mate-applets/1.18.1-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Brian Murray (brian-murray)]

Hello philthynz, or anyone else affected,

Accepted mate-applets into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mate-applets/1.18.1-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Vlad Orlov (monsta)]

Testing in Zesty:

- removed my locally built mate-applets and mate-applets-common
- installed 1.18.1-0ubuntu1.1 from zesty-proposed
- added Sticky Notes applet to mate-panel
- created a new sticky note and typed some text into it
- grabbed the sticky note window by its header and moved it

Testing in Artful:

- removed my locally built mate-applets and mate-applets-common
- installed 1.18.1-1ubuntu0.1 from artful-proposed
- repeated the same Sticky Notes applet tests as in Zesty

In both cases, text selection with mouse works, moving the sticky note window works. All good.

[Hugo Gonzalez (hugonz)]

Just tested on Artful and issue is fixed. Text selection works. Thanks everyone!

[Launchpad Janitor (janitor)]

This bug was fixed in the package mate-applets - 1.18.1-0ubuntu1.1

---------------
mate-applets (1.18.1-0ubuntu1.1) zesty; urgency=medium

  * fix-stickynotes-selection.patch: new patch by Alberts
    Muktupāvels. Fixes text selection in the notes in
    stickynotes applet. (LP: #1675581)

 -- Vlad Orlov <email address hidden> Wed, 20 Sep 2017 17:54:39 +0300

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for mate-applets has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package mate-applets - 1.18.1-1ubuntu0.1

---------------
mate-applets (1.18.1-1ubuntu0.1) artful; urgency=medium

  * fix-stickynotes-selection.patch: new patch by Alberts
    Muktupāvels. Fixes text selection in the notes in
    stickynotes applet. (LP: #1675581)

 -- Vlad Orlov <email address hidden> Sun, 29 Oct 2017 12:23:53 +0300