In placement api error responses choose poor default content-type
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Low
|
Chris Dent |
Bug Description
Because the placement api (up to at least version 1.5) uses webob exceptions and response objects without much modification, when an error response is created it will have a content-type based on any guidance provided in an accept header. If no accept header is present then a textual default (either HTML or text/plain, can't remember right now and it is not relevant) is used.
For a web app that is served through the browser this is a reasonable default, but since the placement api is primarily a JSON-based thing, it would be better to have application/json as the default error format (while still allowing the accept header to be respected).
Now that we are using the wsgi_wrapper.
Care will need to taken to make sure that any error message that wants to use the value of accept isn't compromised.
Changed in nova: | |
assignee: | nobody → Pushkar Umaranikar (pushkar-umaranikar) |
Changed in nova: | |
assignee: | Pushkar Umaranikar (pushkar-umaranikar) → nobody |
Fix proposed to branch: master /review. openstack. org/518223
Review: https:/