html item feeds - cover art lookup based off of ISBN
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
3.1 |
Won't Fix
|
Undecided
|
Unassigned | ||
3.2 |
Won't Fix
|
Undecided
|
Unassigned | ||
3.3 |
Won't Fix
|
Undecided
|
Unassigned | ||
3.4 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
The xsl for converting atom to html tries to add links to cover art based on the titles ISBN, instead of using the newer method of by record ID. Additionally, the current ISBN processing code doesn't seem to handle all ISBN's correctly. Having 020 entries like the following results in no cover art link being generated.
=020 \\$a97814104968
=020 \\$a1410496856$
I found one that did work, and the main difference that I can see is that it only has one 13 digit ISBN.
=020 \\$a9786315169342
The section of ATOM2XHTML.xsl that deals with adding cover art is at -
http://
I'm really clueless about xslt, so I'm not sure what is going wrong here. I think that the code is saying that whenever we are not on the first ISBN entry, and the length is not greater than 9, set the src for the image to a default value for cover art, that won't ever return anything. So any time there is more than one ISBN, the 2nd entry will always cause it to be blanked out. So you will never get cover art for titles with more than one ISBN.
The current behavior can probably be fixed, but it would be better to just use the record ID instead.
I think that maybe the MARC21slim2ATOM.xsl needs to include the 901c, as the URN:RECORDID, since in theory the TCN(001) doesn't need to equal the record ID?
http://
Terran McCanna let me know about this issue and has fixed this for PINES and has provided the files she updated at.
https:/
https:/
Thanks
Josh
Changed in evergreen: | |
milestone: | none → 3.3-rc |
Changed in evergreen: | |
milestone: | 3.3-rc → 3.3.1 |
Changed in evergreen: | |
milestone: | 3.3.1 → 3.3.2 |
Changed in evergreen: | |
milestone: | 3.3.2 → 3.3.3 |
Changed in evergreen: | |
milestone: | 3.3.3 → 3.3.4 |
Changed in evergreen: | |
milestone: | 3.3.4 → 3.3.5 |
Changed in evergreen: | |
milestone: | 3.3.5 → 3.4.2 |
Changed in evergreen: | |
milestone: | 3.4.2 → 3.4.3 |
Changed in evergreen: | |
milestone: | 3.4.3 → 3.4.4 |
Changed in evergreen: | |
milestone: | 3.4.4 → 3.5.1 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
I got the RSS link one of my catalog lists viewed it on an RSS reader (feedly) and noticed that it only had one image (out of 4 total records).
The Fifth Season did not have an image despite having only one 13-digit ISBN 9780316229296
Mr. Penumbra's 24 hour bookstore did have an image--and also had one 13-digit ISBN