Untranslatable string in TPAC summary.tt2

Bug #1673891 reported by Eva Cerninakova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

The message "View all x formats and editions" in /openils/var/templates/opac/parts/record/summary.tt2:270 is not translatable (Evergreen 2.12.rc)

To make it translatable it is possible to replace
   View all [%- args.mmr_unique_bib.size %] formats and editions
by
   [% l("View all ") %] [%- args.mmr_unique_bib.size %] [% l("formats and editions") %]

However, because in the Czech language it is grammatically incorrect to use "all" for "two" (this case can occur when only two formats or editions are grouped) I would rather suggest to make the string translatable similar to a way how the counts of grouped languages (line 260) or grouped formats (line 244) are expressed:

<a href="[%- l( link ) %]">[% l("View all formats and editions") %] ([%- args.mmr_unique_bib.size %])

Eva Cerninakova (ece)
description: updated
Eva Cerninakova (ece)
description: updated
description: updated
Eva Cerninakova (ece)
description: updated
Kathy Lussier (klussier)
Changed in evergreen:
status: New → Triaged
importance: Undecided → Critical
importance: Critical → Medium
assignee: nobody → Kathy Lussier (klussier)
milestone: none → 2.12.0
Revision history for this message
Kathy Lussier (klussier) wrote :

Thanks you Eva! I caught a second untranslatable string in the 'view other formats and editions' header. I made both strings translatable and reworded the second string as Eva recommended.

Working branch is available at
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1673891-sibling-link-untranslatable-string

Changed in evergreen:
assignee: Kathy Lussier (klussier) → nobody
tags: added: i18n pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master and rel_2_12. Thanks, Kathy!

Changed in evergreen:
status: Triaged → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.