"Delete Nodes" button is unlocalized

[Yuko Katabami]

Nodes > Registered

"Delete Nodes" button label is unlocalized.
Translation is available in Zanata:

https://translate.openstack.org/webtrans/translate?project=tripleo-ui&iteration=master&localeId=ja&locale=en-US&dswid=5229#view:doc;doc:i18n/messages;search:delete%20nodes;textflow:623571

https://translate.openstack.org/webtrans/translate?project=tripleo-ui&iteration=stable-ocata&localeId=ja&locale=en-US&dswid=-6883#view:doc;projectsearch:choose%20file;projectsearchin:both;doc:i18n/messages;search:delete%20nodes

I think these are the strings used for this particular button but please correct me if I am wrong.

[Julie Pichon (jpichon)]

I noticed that one as well. It's properly localised in the code:

https://github.com/openstack/tripleo-ui/blob/8d40ed/src/js/components/nodes/RegisteredNodesTabPane.js#L35

but somehow the message id seems to disappear along the way. I'm not sure if it's a problem with the code, the scripts that upload/propose translations or the json2po/pot2json conversion commands... (When I manually add a string for the id in ja.json, the button shows up correctly localised.)

We have other strings used all over the place like "Cancel" that get duplicated correctly so I'm not sure what's up with this particular one.

[Julie Pichon (jpichon)]

I think this might be an issue with the json2pot script. Following the steps at https://github.com/openstack/tripleo-ui/blob/master/docs/translation.rst#extracting-messages-from-components I did:

$ npm run build
$ npm run json2pot

Looking at the output under i18n, the "deleteNodes" id is present in the extracted messages, but not in the pot file:

$ grep -r RegisteredNodesTabPane i18n/

i18n/messages.pot:#: ./i18n/extracted-messages/src/js/components/nodes/RegisteredNodesTabPane.json
i18n/messages.pot:#. [RegisteredNodesTabPane.deleteNodesModalMessage] - undefined
i18n/messages.pot:#: ./i18n/extracted-messages/src/js/components/nodes/RegisteredNodesTabPane.json
i18n/messages.pot:#. [RegisteredNodesTabPane.deleteNodesModalTitle] - undefined
i18n/messages.pot:#: ./i18n/extracted-messages/src/js/components/nodes/RegisteredNodesTabPane.json
i18n/messages.pot:#. [RegisteredNodesTabPane.introspectNodes] - undefined
i18n/messages.pot:#: ./i18n/extracted-messages/src/js/components/nodes/RegisteredNodesTabPane.json
i18n/messages.pot:#. [RegisteredNodesTabPane.provideNodes] - "Providing" the nodes changes the provisioning state to "available" so that they can be used in a deployment.
i18n/messages.pot:#: ./i18n/extracted-messages/src/js/components/nodes/RegisteredNodesTabPane.json
i18n/messages.pot:#. [RegisteredNodesTabPane.tagNodes] - undefined

i18n/extracted-messages/src/js/components/nodes/RegisteredNodesTabPane.json: "id": "RegisteredNodesTabPane.introspectNodes",
i18n/extracted-messages/src/js/components/nodes/RegisteredNodesTabPane.json: "id": "RegisteredNodesTabPane.tagNodes",
i18n/extracted-messages/src/js/components/nodes/RegisteredNodesTabPane.json: "id": "RegisteredNodesTabPane.provideNodes",
i18n/extracted-messages/src/js/components/nodes/RegisteredNodesTabPane.json: "id": "RegisteredNodesTabPane.deleteNodes",
i18n/extracted-messages/src/js/components/nodes/RegisteredNodesTabPane.json: "id": "RegisteredNodesTabPane.deleteNodesModalTitle",
i18n/extracted-messages/src/js/components/nodes/RegisteredNodesTabPane.json: "id": "RegisteredNodesTabPane.deleteNodesModalMessage",

[Julie Pichon (jpichon)]

I think this may be due to this bug:

https://github.com/evenchange4/react-intl-po/issues/59

aka problem with the same "defaultMessage" defined twice in the same file, which is the case here. It looks like it's fixed in version 2.0.0 of the library. We're currently using "react-intl-po": "^1.1.0", I guess we might need to make "2.0.0 or higher" specific?

Unfortunately since this requires a dependency update I don't think we will be able to backport it to Ocata... :/

[Emilien Macchi (emilienm)]

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (FUTURE, PIKE, QUEENS, ROCKY, STEIN).
  Valid example: CONFIRMED FOR: FUTURE