Update adwaita-icon-theme to 3.23.91.1

[Jeremy Bícha]

I don't have upload rights for adwaita-icon-theme so debdiff attached.

Many icons have been updated this cycle.

https://git.gnome.org/browse/adwaita-icon-theme/tree/NEWS
https://git.gnome.org/browse/adwaita-icon-theme/log

zesty's gnome-shell 3.23/3.24 needs the new night-light icon.

[Sebastien Bacher (seb128)]

thanks, we are after ff though so you might want do a summary of the changes in the update/give a rational for going to a new major serie now, also maybe subscribe ubuntu-sponsors?

[Jeremy Bícha (jbicha)]

Thanks, I added a bit more detail. But I believe this is a User Interface change, not a Feature change so we're still ahead of the Freeze.

https://wiki.ubuntu.com/ZestyZapus/ReleaseSchedule

[Iain Lane (laney)]

Please post a binary debdiff so that we can check there aren't any other problems like bug #1669655 waiting for us.

[Jeremy Bícha (jbicha)]

$ debdiff adwaita-icon-theme_3.22.0-1ubuntu1_all.deb adwaita-icon-theme_3.23.91.1-0ubuntu1_all.deb

Files in second .deb but not in first
-------------------------------------
-rw-r--r-- root/root /usr/share/icons/Adwaita/512x512/apps/accessories-character-map.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/512x512/devices/input-dialpad.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/512x512/emblems/emblem-readonly.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/512x512/emblems/emblem-unreadable.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/512x512/mimetypes/application-x-executable.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/512x512/mimetypes/text-x-preview.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/scalable/apps/preferences-desktop-keyboard-symbolic.svg
-rw-r--r-- root/root /usr/share/icons/Adwaita/scalable/status/daytime-sunrise-symbolic.svg
-rw-r--r-- root/root /usr/share/icons/Adwaita/scalable/status/daytime-sunset-symbolic.svg
-rw-r--r-- root/root /usr/share/icons/Adwaita/scalable/status/night-light-symbolic.svg

Files in first .deb but not in second
-------------------------------------
-rw-r--r-- root/root /usr/share/icons/Adwaita/16x16/apps/system-file-manager.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/22x22/apps/system-file-manager.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/24x24/apps/system-file-manager.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/256x256/apps/accessories-character-map.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/256x256/apps/system-file-manager.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/256x256/devices/input-dialpad.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/256x256/emblems/emblem-readonly.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/256x256/emblems/emblem-unreadable.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/256x256/mimetypes/application-x-executable.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/256x256/mimetypes/text-x-preview.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/256x256/mimetypes/x-office-presentation.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/32x32/apps/system-file-manager.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/48x48/apps/system-file-manager.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/scalable/apps/system-file-manager-symbolic.svg

$ debdiff adwaita-icon-theme-full_3.22.0-1ubuntu1_all.deb adwaita-icon-theme-full_3.23.91.1-0ubuntu1_all.deb

Files in second .deb but not in first
-------------------------------------
-rw-r--r-- root/root /usr/share/doc/adwaita-icon-theme-full/changelog.Debian.gz
-rw-r--r-- root/root /usr/share/icons/Adwaita/16x16/apps/preferences-desktop-keyboard-symbolic.symbolic.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/16x16/status/daytime-sunrise-symbolic.symbolic.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/16x16/status/daytime-sunset-symbolic.symbolic.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/16x16/status/night-light-symbolic.symbolic.png
-rw-r--r-- root/root /usr/share/icons/Adwaita/24x24/apps/preferences-desktop-keyboard-symbolic.symbolic.png
-rw-r--r-- root/root ...

[Jeremy Bícha (jbicha)]

The diff is noisy. 256px icons have been replaced in many cases by 512px icons.

There are two icons that had their 256px versions dropped but did not have a 512px icon replacement:
mimetypes/x-office-presentation.png
mimetypes/x-office-address-book.png

So I opened https://bugzilla.gnome.org/779715 about it.

Those icons are available in other sizes so I don't think this should block this upload since I expect that to be fixed in 3.23.92 for zesty.

[Jeremy Bícha (jbicha)]

And I opened https://bugzilla.gnome.org/779507 about dropping system-file-manager

[Iain Lane (laney)]

Uploaded.

I think those two bugs are reasonably easy ones to contribute fixes for upstream. It would be nice if you were to do that. Especially the first one so that we continue to have decent sized icons. 48x48 isn't really that good.

[Jeremy Bícha (jbicha)]

Well the bug fixes are simple reversions. The problem is convincing GNOME to do it. I am trying though.

[Launchpad Janitor (janitor)]

This bug was fixed in the package adwaita-icon-theme - 3.23.91.1-0ubuntu1

---------------
adwaita-icon-theme (3.23.91.1-0ubuntu1) zesty; urgency=medium

  * New upstream release (LP: #1669158)
  * Drop patch, applied in new release

 -- Jeremy Bicha <email address hidden> Thu, 09 Mar 2017 23:01:42 +0000

[Iain Lane (laney)]

On Thu, Mar 09, 2017 at 11:40:59PM -0000, Jeremy Bicha wrote:
> Well the bug fixes are simple reversions. The problem is convincing
> GNOME to do it. I am trying though.

Attaching patches to bugs often works.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[Jeremy Bícha (jbicha)]

Yes, it worked this time! :)

https://git.gnome.org/browse/adwaita-icon-theme/log

[Iain Lane (laney)]

On Fri, Mar 10, 2017 at 02:09:32PM -0000, Jeremy Bicha wrote:
> Yes, it worked this time! :)
>
> https://git.gnome.org/browse/adwaita-icon-theme/log

Nice one!

I think we can wait for the release to grab those, but lemme know if you
disagree.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[Jeremy Bícha (jbicha)]

According to the schedule, there should be a RC next week and the final 3.24.0 release the week after. I'm fine with waiting until 3.24.0 for these fixes.

https://wiki.gnome.org/ThreePointTwentythree