SIP is not respecting standing penalties for charge ok and hold ok
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned |
Bug Description
This might be related to LP1534283
SIP currently allows a user to circulate with standing penalties that specifically block CIRC.
SIP currently allows a user to place holds with standing penalties that specifically block HOLD.
When handling a Patron Info (63) message, one of the values consulted is the SIP patron object's hold_ok value, which is currently just a copy of their charge_ok value.
charge_ok and hold_ok need to take a look at the specific penalties and the actions that those penalties block.
6300120170112 060147 AO|AA{patron barcode that has a penalty with block list CIRC}|AC|
results in
64 Y 00020170127.
it should be
64Y Y 00020170127.
tags: | added: signedoff |
Changed in evergreen: | |
milestone: | none → 3.0-alpha |
assignee: | nobody → Galen Charlton (gmc) |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Here is what I got
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ blake/LP1659928 _SIP_is_ not_respecting_ standing_ penalties_ for_charge_ ok_and_ hold_ok
I originally wrote the section on renewing for LP1534283 /bugs.launchpad .net/evergreen/ +bug/1534283
https:/
This patch rewrites that and charge_ok and hold_ok to be consistent.