SIP prevents renewal when user has any blocking standing penalties

Bug #1534283 reported by Jeff Godin
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Fix Released

Bug Description

SIP currently prevents renewal when a user has any blocking standing penalties, even when the block list for a given penalty does not block renewal.

When handling a Renew (29) message, one of the values consulted is the SIP patron object's renew_ok value, which is currently just a copy of their charge_ok value.

This means that anything blocking checkout will also block renewal (via SIP).

Included in the checks for charge_ok is an explicit assumption that standing penalty ids 1 and 2 will block (though their block_list may have been modified), and that any standing penalties with a non-null block_list will block.

Revision history for this message
Blake GH (bmagic) wrote :
tags: added: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :

Pushed to master, thanks!

Changed in evergreen:
status: New → Fix Committed
milestone: none → 2.11-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers