lshw package update - ppc64le

Bug #1655102 reported by bugproxy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The Ubuntu-power-systems project
Fix Released
Undecided
Unassigned
lshw (Ubuntu)
Fix Released
Undecided
Steve Langasek

Bug Description

lshw package update for ppc64le in Ubuntu 17.04

lshw (Hardware Lister) is a small tool to provide detailed information on the hardware configuration of the machine. It can report exact memory configuration, firmware version, mainboard configuration, CPU version and speed, cache configuration, bus speed, etc. on DMI-capable x86 or EFI (IA-64) systems and on some PowerPC machines

This FEAT is mostly to push any Power specific issues and validation purpose.

bugproxy (bugproxy)
tags: added: architecture-ppc64le bugnameltc-149860 severity-medium targetmilestone-inin1704
Changed in ubuntu:
assignee: nobody → Taco Screen team (taco-screen-team)
affects: ubuntu → lshw (Ubuntu)
Revision history for this message
Steve Langasek (vorlon) wrote :

this is not an actionable bug report, nothing is specified about the version of lshw needed for ppc64el in 17.04.

Changed in lshw (Ubuntu):
status: New → Incomplete
Revision history for this message
Breno Leitão (breno-leitao) wrote :

Hi Steve, I just posted the requested commits ids that should be cherry picked

Changed in lshw (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2017-01-10 06:32 EDT-------
> The commits which have already gone upstream, after 2.18 release
> clean-up(commit 204b1aae40), in sequence, are:
>
> cb3c2999b5
> a5fb8431d9
> [6a75f4e52f..0ea2e95b3c] both ends inclusive and excluding merge commit:
> f9bdcc342d
>
>
> Thanks and Regards.

Revision history for this message
bugproxy (bugproxy) wrote : lshw
  • lshw Edit (9.8 KiB, application/octet-stream)

------- Comment (attachment only) From <email address hidden> 2017-01-16 04:27 EDT-------

bugproxy (bugproxy)
tags: removed: bugnameltc-149860 severity-medium
Revision history for this message
bugproxy (bugproxy) wrote :
  • lshw Edit (18.8 KiB, application/octet-stream)

------- Comment (attachment only) From <email address hidden> 2017-01-18 00:14 EDT-------

tags: added: bugnameltc-149860 severity-medium
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2017-01-20 07:51 EDT-------
(In reply to comment #18)
> Hi Steve, I just posted the requested commits ids that should be cherry
> picked

Can you please pick these patchset to both Zesty and Xenial LTS series?

-Vasant

Revision history for this message
Steve Langasek (vorlon) wrote :

cb3c2999b5 has already been fixed equivalently in Ubuntu since 02.18-0ubuntu1 in yakkety.

a5fb8431d9 does not apply cleanly against our tree because we are already carrying 2c38e1c6a9, a commit from Jeremy Kerr in June 2015 submitted to us by IBM in bug #1585186. This commit is not upstream. Has it been submitted upstream? Is it still needed or should it be dropped?

Steve Langasek (vorlon)
Changed in lshw (Ubuntu):
status: Confirmed → Fix Committed
assignee: Taco Screen team (taco-screen-team) → Steve Langasek (vorlon)
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2017-03-23 04:53 EDT-------
(In reply to comment #30)
> cb3c2999b5 has already been fixed equivalently in Ubuntu since
> 02.18-0ubuntu1 in yakkety.
>
> a5fb8431d9 does not apply cleanly against our tree because we are already
> carrying 2c38e1c6a9, a commit from Jeremy Kerr in June 2015 submitted to us
> by IBM in bug #1585186. This commit is not upstream. Has it been submitted
> upstream? Is it still needed or should it be dropped?

We ended up submitting different patch to upstream. I think we can drop Jeremy's patch and pull upstream one.

Upstream patch for fw version :

commit 3abc9878e862d3401f2e5b3eb9e507f10bad7e2e
Author: Jack Miller <email address hidden>
Date: Tue Aug 23 15:18:47 2016 -0500

devtree: Add parsed firmware version info

Revision history for this message
Steve Langasek (vorlon) wrote :

> We ended up submitting different patch to upstream. I think we can drop Jeremy's patch and pull upstream one.

> Upstream patch for fw version :

> commit 3abc9878e862d3401f2e5b3eb9e507f10bad7e2e
> Author: Jack Miller <email address hidden>
> Date: Tue Aug 23 15:18:47 2016 -0500

> devtree: Add parsed firmware version info

Are you sure that these two commits are equivalent? The one you reference doesn't look at /ibm,opal at all.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lshw - 02.18-0.1ubuntu2

---------------
lshw (02.18-0.1ubuntu2) zesty; urgency=medium

  * debian/patches/merge-github-pull-request-23-parse-CPU-information.patch,
    debian/patches/devtree-*,
    debian/patches/cpuinfo-Rectify-cpuinfo-for-IBM-Power-Systems.patch,
    debian/patches/pci-Add-device-tree-info.patch: cherry-pick from upstream.
    LP: #1655102.
  * debian/patches/Parse-OPAL-firmware-properties-from-the-device-tree.patch:
    fix up patch to apply on top of above upstream patch.

 -- Steve Langasek <email address hidden> Tue, 21 Mar 2017 18:53:48 -0700

Changed in lshw (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2017-03-28 12:29 EDT-------
(In reply to comment #32)
> > We ended up submitting different patch to upstream. I think we can drop Jeremy's patch and pull upstream one.
>
> > Upstream patch for fw version :
>
> > commit 3abc9878e862d3401f2e5b3eb9e507f10bad7e2e
> > Author: Jack Miller <email address hidden>
> > Date: Tue Aug 23 15:18:47 2016 -0500
>
> > devtree: Add parsed firmware version info
>
> Are you sure that these two commits are equivalent? The one you reference
> doesn't look at /ibm,opal at all.

Ok.. Initially we added firmware version under /ibm,opal node under DT... but later it was changed to /ibm,firmware-versions.

Hence it safe to remove Jeremy's original patch and use upstream patch.

-Vasant

Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2017-04-04 05:31 EDT-------
I see that 2 patches have gone ignored here:

https://ezix.org/src/pkg/lshw/commit/24f587ab0128c688f38ebf0241bc431a79860b7c and
https://ezix.org/src/pkg/lshw/commit/503c76a35a9e97a098af7c1ac793a7e13c07ce70

They are a part of:

> [6a75f4e52f..0ea2e95b3c] both ends inclusive and excluding merge commit:
> f9bdcc342d

as I mentioned in https://bugzilla.linux.ibm.com/show_bug.cgi?id=149860#c16

Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2017-04-05 09:02 EDT-------
(In reply to comment #36)
> I see that 2 patches have gone ignored here:
>
> https://ezix.org/src/pkg/lshw/commit/
> 24f587ab0128c688f38ebf0241bc431a79860b7c and
> https://ezix.org/src/pkg/lshw/commit/
> 503c76a35a9e97a098af7c1ac793a7e13c07ce70
>
>
> They are a part of:
>
> > [6a75f4e52f..0ea2e95b3c] both ends inclusive and excluding merge commit:
> > f9bdcc342d
>
> as I mentioned in https://bugzilla.linux.ibm.com/show_bug.cgi?id=149860#c16

Apart from that, everything looks good.
(Verified on LPARs, fsp based PowerNV host and guest and BMC based PowerNV host.)

Manoj Iyer (manjo)
Changed in ubuntu-power-systems:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.