Empty translations are counted as completed translations

[Steven Harper]

As seen in Italian's entry at https://translations.launchpad.net/easycrypt/trunk/+pots/easycrypt

statistics doesn't match because we are counting empty translations coming from .po files as messages completely translated.

[Carlos Perelló Marín (carlos)]

This is a regression with our recent refactoring

[Данило Шеган (danilo)]

Carlos, I think the problem is a bit different here: the fix should be as simple as https://pastebin.canonical.com/1195/ (note that the count of 'changed in launchpad' is exactly 60, and untranslated is calculated as "total - imported (currentCount) - new (rosettaCount)" without taking "changed in LP" (updatesCount) into account).

[Carlos Perelló Marín (carlos)]

Hmm, that seems to fix part of the problem but not the whole one.

If you browse the Italian translations: https://translations.launchpad.net/easycrypt/trunk/+pots/easycrypt/it/+translate you can see how we are showing that we diverged completely from what upstream had, although those translations from upstream is the empty string...

[Данило Шеган (danilo)]

Things to fix for this:
 - Use is_empty before displaying 'Packaged' suggestion
 - Fix getPOTMsgSetsChangedInLaunchpad to not return is_empty translation messages
 - Fix RosettaStats translatedCount method to take updatesCount into account
 - Do not create is_empty imported messages (they are useful only for translations through LP), if we're overriding existing imported message, just unset the is_imported flag

[Carlos Perelló Marín (carlos)]

Fixed in RF 5253

[Carlos Perelló Marín (carlos)]

Moved back to 'Confirmed' so we implement a proper fix, prevent any TranslationMessage created with all msgstr? as NULL for is_imported ones. If we get that situation, instead of create an empty one, we should unset the is_imported flag.

[Carlos Perelló Marín (carlos)]

Also, once the fix lands, we should execute: https://pastebin.canonical.com/1234/ in production to clean the database.

[Данило Шеган (danilo)]

Ok, so this is how it's working out:
 - not showing packaged is_empty translations is now #173928 (to be in review shortly)
 - stats problem is actually not what I described above, but rather #173527 (description still says the same thing, but look at the comment below): to be in review shortly as well
 - Carlos has already fixed the changed-in-LP filter with RF 5253.
 - creating empty translationmessages for imported messages needs more discussion (i.e. I think we should still create them if previous import had something translated, and now it's being unset, so we can log whose import [last-translator, uploader] actually did this).

[Jeroen T. Vermeulen (jtv)]

The user-visible issues here have been addressed individually. Downgrading the rest to Medium and moving into 2008.

[Jeroen T. Vermeulen (jtv)]

The only thing left to address is exactly what empty translation messages are worth keeping in the database, and to get rid of the rest. That's in bug 183491.