please merge samba 3.0.27a-1 (main) from Debian unstable (main)

Bug #165072 reported by Steve Langasek
4
Affects Status Importance Assigned to Milestone
samba (Ubuntu)
Fix Released
Wishlist
Steve Langasek

Bug Description

Binary package hint: samba

Changelog since current hardy version 3.0.26a-1ubuntu2:

 samba (3.0.27a-1ubuntu1) hardy; urgency=low
 .
   * Merge from debian unstable, remaining changes:
     * debian/patches/VERSION.patch:
       - set SAMBA_VERSION_VENDOR_SUFFIX to Ubuntu
     * debian/control:
       - Remove typehandling (not used in Ubuntu)
     * debian/rules:
       - Remove type-handling.
     * debian/samba.init:
       - Ubuntu's log_progress_msg is a no-op, so to avoid confusion, don't
         say specifically which daemons we're handling. (LP #25803)
     * debian/smb.conf:
       - Add "(Samba, Ubuntu)" to server string.
       - Comment out the default [homes] shares and add more verbose comments to
         explain what they do and how they work (LP #27608). Also, add a
         comment about "valid users = %S" to show users how to restrict access
         to \\server\username to only username.
     * debian/panic-action:
       - Bail out if there's no "mail" command.
       - Alter the panic-action script to link to the samba bug reporting page
         on Launchpad.
     * debian/samba-common.config:
       - do not change priority to HIGH if dhclient3 is installed
       - use priority medium instead of high for the workgroup question
 .
 samba (3.0.27a-1) unstable; urgency=low
 .
   [ Steve Langasek ]
   * New upstream release
     - fix regression with smbfs clients, introduced by the security fix in
       3.0.27. Closes: #451839.
     - debian/patches/cifs-umount-trailing-slashes.patch: merged upstream.
   * Drop the deprecated "printer admin" example from the default smb.conf.
     Closes: #451273.
   * Add a *new* debian/patches/cups.patch to *enable* cups as the default
     printing system, because since the original introduction of this patch
     in Debian there was a regression upstream that caused cups to never be
     selected as the default print system.
   * Set the default value for the workgroup question to "WORKGROUP" in
     samba-common.templates, not just in the template smb.conf, so that the
     debconf question comes out right every time; and always treat this
     as a high-priority debconf question instead of selecting the
     priority based on whether there's an existing value, since there's
     now *always* an existing value but the value doesn't tell us
     anything meaningful about the user's preference. Closes: #451271.
   * Drop some code from samba.postinst that only applies to upgrades from
     pre-3.0 (i.e., pre-sarge) packages
 .
   [ Christian Perrier ]
   * Update the "built by" part of README.debian
   * Remove the very outdated parts of README.debian
 .
 samba (3.0.27-1) unstable; urgency=low
 .
   * New upstream version
     - fixes a remote code execution vulnerability when running nmbd as a
       WINS server. (CVE-2007-5398; closes: #451385)
     - fixes a buffer overflow in nmbd when running as a domain controller
       during processing of GETDC logon server requests. (CVE-2007-4572)
 .
   [ Steve Langasek ]
   * fhs.patch: net usershares should also be stored under /var/lib, not under
     /var/run. No transition handling in maintainer scripts, since this
     feature is not activated by default.
   * get_global_sam_sid-non-root.patch: avoid calling get_global_sam_sid()
     from smbpasswd -L or pam_smbpass when running as non-root, to avoid a
     foreseeable panic. Closes: #346547, #450738.
   * usershare.patch: enable "user shares" by default in the server with a
     default limit of 100, to support user shares on both upgrades and new
     installs with no need to munge config files. Thanks to Mathias Gug
     <email address hidden> for the patch. Closes: #443230.
   * On Ubuntu, support autopopulating the sambashare group using the existing
     members of the admin group; no equivalent handling is done on Debian,
     because there doesn't seem to be an appropriate template group we can use
     that wouldn't be considered a privilege escalation for those users.
   * Update Samba to explicitly use the C locale when doing password changes,
     to account for Linux-PAM's recently adopted i18n support.
     Closes: #451272.
   * Enforce creation of the pid directory (/var/run/samba) in the samba
     init script, for compatibility with systems that use a tmpfs for
     /var/run. Closes: #451270.
   * debian/patches/cups.patch, debian/NEWS: drop the patch to force bsd
     as the default printing system, as CUPS is now the dominant/default
     printing system for Linux.
 .
   [ Debconf translations ]
   * Hebrew added. Closes: #444054
 .
   [ Christian Perrier ]
   * Split fhs.patch into 3 separate patches to make upstream integration
     easier:
     - fhs-newpaths.patch: introduce new paths
     - fhs-filespaths.patch: assign files to new paths
     - fhs-assignpaths.patch: assign paths to FHS-compatible locations
   * Compile with DNS update support. Thanks to Matthias Gug for
     reporting and contributions from Launchpad's #156686
     Closes: #449422

Related branches

CVE References

Steve Langasek (vorlon)
Changed in samba:
assignee: nobody → vorlon
importance: Undecided → Wishlist
status: New → In Progress
Revision history for this message
Steve Langasek (vorlon) wrote :
Revision history for this message
Steve Langasek (vorlon) wrote :

Comments on the changes dropped since the last Ubuntu version:

- debian/samba-common.templates and changes under debian/po - Ubuntu had diverged unnecessarily from Debian on the template description due to a past incorrect merge, resulting in fuzzy translations. This has now been corrected. Also, Ubuntu used a different default workgroup name than the upstream default; this was discussed in Debian bug #451271, and the conclusion is that the Debian default is correct.
- debian/rules - Ubuntu used an option of --error-handler=true to catch errors starting samba on package configuration, in response to LP bug #85194. This was discussed in Debian bug #451269, with the conclusion that this was not the correct fix for the problem, so has been reverted here.
- debian/smb.conf - "printer admin" is a deprecated option, so should be dropped completely from the examples.

Revision history for this message
Mathias Gug (mathiaz) wrote :

Thanks for the debdiff.

The patch itself looks good to me.

I have a few comments on the changelog entry:
   * I'd add a section about which bugs have been fixed with the merge:
      - Enable net user share (LP: #128548).
   * I'd add a section about dropped patches, with a short version of your previous comment (https://bugs.launchpad.net/ubuntu/+source/samba/+bug/165072/comments/6).
   * In the panic action script entry, "doesn't bail out..." should be dropped as it's no longer in the diff.
   * In the smb.conf entry, I'd add an entry related to the "passwd chat" option.
   * In the control entry, I'd mention the Maintainer field update.

Revision history for this message
Steve Langasek (vorlon) wrote :

Thanks for the comments, Mathias. Attached is a new debdiff with updated changelog, incorporating your feedback.

Revision history for this message
Mathias Gug (mathiaz) wrote : Re: [Bug 165072] Re: please merge samba 3.0.27a-1 (main) from Debian unstable (main)

On Thu, Nov 29, 2007 at 12:30:29AM -0000, Steve Langasek wrote:
> Thanks for the comments, Mathias. Attached is a new debdiff with
> updated changelog, incorporating your feedback.
>

Thanks Steve. The merge looks good to me.

--
Mathias

Revision history for this message
Soren Hansen (soren) wrote :

So we're changing the workgroup that has been the default in Ubuntu
since Warty, because Debian doesn't want to adopt that change?

The fact that Microsoft hasn't managed to be consistent doesn't mean
that we shouldn't be.

--
Soren Hansen
Ubuntu Server Team
http://www.ubuntu.com/

Revision history for this message
Mathias Gug (mathiaz) wrote :

Hi Soren,

On Mon, Dec 03, 2007 at 09:35:50AM -0000, Soren Hansen wrote:
> So we're changing the workgroup that has been the default in Ubuntu
> since Warty, because Debian doesn't want to adopt that change?
>

This was discussed in Debian:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=451271

--
Mathias

Revision history for this message
Steve Langasek (vorlon) wrote :

Updated debdiff, including an explanation for the change in default workgroup value; sorry for omitting this earlier, this information should of course be available in the Ubuntu package/bug log and not just in the Debian bug.

Revision history for this message
Steve Langasek (vorlon) wrote :
Download full text (5.7 KiB)

samba (3.0.27a-1ubuntu1) hardy; urgency=low

  * Merge from debian unstable (LP: #165072), remaining changes:
    * debian/patches/VERSION.patch:
      - set SAMBA_VERSION_VENDOR_SUFFIX to Ubuntu
    * debian/control:
      - Remove type-handling (not used in Ubuntu)
    * debian/rules:
      - Remove type-handling.
    * debian/samba.init:
      - Ubuntu's log_progress_msg is a no-op, so to avoid confusion, don't
        say specifically which daemons we're handling. (LP #25803)
    * debian/smb.conf:
      - Add "(Samba, Ubuntu)" to server string.
      - Comment out the default [homes] shares and add more verbose comments to
        explain what they do and how they work (LP #27608). Also, add a
        comment about "valid users = %S" to show users how to restrict access
        to \\server\username to only username.
      - default passwd chat value is modified
    * debian/panic-action:
      - Alter the panic-action script to link to the samba bug reporting page
        on Launchpad.
    * debian/samba-common.config:
      - do not change priority to HIGH if dhclient3 is installed
      - use priority medium instead of high for the workgroup question
    * Set Ubuntu maintainer address.
  * Bugs fixed in Debian:
    - Enable net usershare (LP: #128548)
  * Ubuntu patches merged in Debian:
    * debian/smb.conf:
      - "printer admin" is a deprecated option, and is dropped
        completely from the examples.
    * debian/samba-common.templates:
      - Default workgroup value is now set to WORKGROUP; this is a
        change from previous Ubuntu versions which used MSHOME, but is
        consistent with the Samba upstream defaults and the default
        behavior for most versions of Windows.
  * Ubuntu patches dropped:
    * debian/rules:
      - Samba should not use --error-handler=true for its init script.
    * debian/samba-common.templates, debian/po/*.po:
      - unnecessary divergence from Debian debconf template which
        resulted in fuzzy translations; this is cleaned up now

samba (3.0.27a-1) unstable; urgency=low

  [ Steve Langasek ]
  * New upstream release
    - fix regression with smbfs clients, introduced by the security fix in
      3.0.27. Closes: #451839.
    - debian/patches/cifs-umount-trailing-slashes.patch: merged upstream.
  * Drop the deprecated "printer admin" example from the default smb.conf.
    Closes: #451273.
  * Add a *new* debian/patches/cups.patch to *enable* cups as the default
    printing system, because since the original introduction of this patch
    in Debian there was a regression upstream that caused cups to never be
    selected as the default print system.
  * Set the default value for the workgroup question to "WORKGROUP" in
    samba-common.templates, not just in the template smb.conf, so that the
    debconf question comes out right every time; and always treat this
    as a high-priority debconf question instead of selecting the
    priority based on whether there's an existing value, since there's
    now *always* an existing value but the value doesn't tell us
    anything meaningful about the user's preference. Closes: #451271.
  * Drop some code from samba.postinst that only...

Read more...

Changed in samba:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.