Error on Content Deletion

[Nat Katin-Borland]

Hi Guys,

When deleting content on KARL an error screen is getting thrown. The content gets deleted, but instead of just seamlessly passing the user back to the KARL homepage, an error screen comes up and users think that their content deletion has not been successful. This is happening across browsers.

[Paul Everitt (paul-agendaless)]

Carlos, can you take a look? I'm at the airport in Munich.

That’s weird, it is an error that doesn’t get caught by us and reported to Nagios.

Here’s the traceback:

Traceback (most recent call last):
  File "/srv/osfkarl/production/88/eggs/waitress-0.8.9-py2.7.egg/waitress/channel.py", line 337, in service
    task.service()
  File "/srv/osfkarl/production/88/eggs/waitress-0.8.9-py2.7.egg/waitress/task.py", line 173, in service
    self.execute()
  File "/srv/osfkarl/production/88/eggs/waitress-0.8.9-py2.7.egg/waitress/task.py", line 392, in execute
    app_iter = self.channel.server.application(env, start_response)
  File "/srv/osfkarl/production/88/eggs/perfmetrics-2.0-py2.7.egg/perfmetrics/__init__.py", line 294, in app
    return nextapp(environ, start_response)
  File "/srv/osfkarl/production/88/eggs/karl-4.22.1-py2.7.egg/karl/timeit.py", line 49, in __call__
    resp = req.get_response(self.app)
  File "/srv/osfkarl/production/88/eggs/WebOb-1.1.1-py2.7.egg/webob/request.py", line 1086, in get_response
    application, catch_exc_info=False)
  File "/srv/osfkarl/production/88/eggs/WebOb-1.1.1-py2.7.egg/webob/request.py", line 1055, in call_application
    app_iter = application(self.environ, start_response)
  File "/srv/osfkarl/production/88/eggs/guillotine-0.1-py2.7.egg/guillotine/__init__.py", line 10, in __call__
    return self.app(environ, start_response)
  File "/srv/osfkarl/production/88/eggs/repoze.vhm-0.13-py2.7.egg/repoze/vhm/middleware.py", line 106, in __call__
    return self.application(environ, start_response)
  File "/srv/osfkarl/production/88/eggs/repoze.browserid-0.3-py2.7.egg/repoze/browserid/middleware.py", line 127, in __call__
    return self.app(environ, start_response)
  File "/srv/osfkarl/production/88/eggs/repoze.urchin-0.2-py2.7.egg/repoze/urchin/__init__.py", line 53, in __call__
    resp = req.get_response(self.app)
  File "/srv/osfkarl/production/88/eggs/WebOb-1.1.1-py2.7.egg/webob/request.py", line 1086, in get_response
    application, catch_exc_info=False)
  File "/srv/osfkarl/production/88/eggs/WebOb-1.1.1-py2.7.egg/webob/request.py", line 1055, in call_application
   app_iter = application(self.environ, start_response)
  File "/srv/osfkarl/production/88/eggs/pyramid-1.2.1-py2.7.egg/pyramid/router.py", line 177, in __call__
    has_listeners and notify(NewResponse(request, response))
  File "/srv/osfkarl/production/88/eggs/pyramid-1.2.1-py2.7.egg/pyramid/registry.py", line 61, in notify
    [ _ for _ in self.subscribers(events, None) ]
  File "/srv/osfkarl/production/88/eggs/zope.component-3.6.0-py2.7.egg/zope/component/registry.py", line 315, in subscribers
    return self.adapters.subscribers(objects, provided)
  File "/srv/osfkarl/production/88/eggs/zope.interface-3.8.0-py2.7-linux-i686.egg/zope/interface/adapter.py", line 583, in subscribers
    subscription(*objects)
  File "/srv/osfkarl/production/88/eggs/karl-4.22.1-py2.7.egg/karl/subscribers.py", line 28, in request_logger
    profile = profiles.get(userid, None)
AttributeError: 'NoneType' object has no attribute ‘get'

[Paul Everitt (paul-agendaless)]

Nat, can you recreate this?

[Nat Katin-Borland (nborland)]

Yes, it happens every time you delete something - at least blog posts, communities - probably other content types as well...

--
Nathaniel Katin-Borland
Business Analyst | Information Systems
Open Society Foundations | New York | 224 W 57th Street, NY, NY 10019
Office: [phone]
<email address hidden>
http://www.opensocietyfoundations.org

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Paul Everitt
Sent: Friday, December 16, 2016 10:59 AM
To: Nathaniel Katin-Borland
Subject: [Bug 1650590] Re: Error on Content Deletion

Nat, can you recreate this?

--
You received this bug notification because you are subscribed to the bug report.
https://bugs.launchpad.net/bugs/1650590

Title:
  Error on Content Deletion

Status in KARL4:
  New

Bug description:
  Hi Guys,

  When deleting content on KARL an error screen is getting thrown. The
  content gets deleted, but instead of just seamlessly passing the user
  back to the KARL homepage, an error screen comes up and users think
  that their content deletion has not been successful. This is
  happening across browsers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/karl4/+bug/1650590/+subscriptions

[Carlos de la Guardia (cguardia)]

I pushed a fix, but I am not able to do a full release right now, so I cheated a bit and patched the file in place.

Nat, can you try this out?

[Nat Katin-Borland (nborland)]

Hi Carlos,

Am I trying this out in production or on staging?

Staging seems down. I just tried deleting something prod and still go the error.

-Nat

--
Nathaniel Katin-Borland
Business Analyst | Information Systems
Open Society Foundations | New York | 224 W 57th Street, NY, NY 10019
Office: [phone]
<email address hidden>
http://www.opensocietyfoundations.org

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Carlos de la Guardia
Sent: Friday, December 16, 2016 3:09 PM
To: Nathaniel Katin-Borland
Subject: [Bug 1650590] Re: Error on Content Deletion

I pushed a fix, but I am not able to do a full release right now, so I cheated a bit and patched the file in place.

Nat, can you try this out?

--
You received this bug notification because you are subscribed to the bug report.
https://bugs.launchpad.net/bugs/1650590

Title:
  Error on Content Deletion

Status in KARL4:
  New

Bug description:
  Hi Guys,

  When deleting content on KARL an error screen is getting thrown. The
  content gets deleted, but instead of just seamlessly passing the user
  back to the KARL homepage, an error screen comes up and users think
  that their content deletion has not been successful. This is
  happening across browsers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/karl4/+bug/1650590/+subscriptions

[Carlos de la Guardia (cguardia)]

Production. I had restarted osf10, but not osf11. Please try again.

[Nat Katin-Borland (nborland)]

Still getting the same error...

--
Nathaniel Katin-Borland
Business Analyst | Information Systems
Open Society Foundations | New York | 224 W 57th Street, NY, NY 10019
Office: [phone]
<email address hidden>
http://www.opensocietyfoundations.org

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Carlos de la Guardia
Sent: Friday, December 16, 2016 3:43 PM
To: Nathaniel Katin-Borland
Subject: [Bug 1650590] Re: Error on Content Deletion

Production. I had restarted osf10, but not osf11. Please try again.

--
You received this bug notification because you are subscribed to the bug report.
https://bugs.launchpad.net/bugs/1650590

Title:
  Error on Content Deletion

Status in KARL4:
  New

Bug description:
  Hi Guys,

  When deleting content on KARL an error screen is getting thrown. The
  content gets deleted, but instead of just seamlessly passing the user
  back to the KARL homepage, an error screen comes up and users think
  that their content deletion has not been successful. This is
  happening across browsers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/karl4/+bug/1650590/+subscriptions

[Carlos de la Guardia (cguardia)]

The fix needed to be applied somewhere else in the code too. Sorry.

I can confirm that I was able to delete files correctly now.

[Paul Everitt (paul-agendaless)]

The app servers are 11 and 12. 10 is used for the tasks.

Sent from my iPhone

> On Dec 17, 2016, at 05:21, Carlos de la Guardia <email address hidden> wrote:
>
> The fix needed to be applied somewhere else in the code too. Sorry.
>
> I can confirm that I was able to delete files correctly now.
>
> --
> You received this bug notification because you are subscribed to KARL4.
> Matching subscriptions: KARL4
> https://bugs.launchpad.net/bugs/1650590
>
> Title:
> Error on Content Deletion
>
> Status in KARL4:
> New
>
> Bug description:
> Hi Guys,
>
> When deleting content on KARL an error screen is getting thrown. The
> content gets deleted, but instead of just seamlessly passing the user
> back to the KARL homepage, an error screen comes up and users think
> that their content deletion has not been successful. This is
> happening across browsers.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl4/+bug/1650590/+subscriptions

[Carlos de la Guardia (cguardia)]

The fix works, so you can make a release any time now.

[Carlos de la Guardia (cguardia)]

By the way, all servers have been patched manually, so its not urgent.