bootcd FTBFS on hardy

[Nicolas Valcarcel]

Binary package hint: bootcd

bootcd FTBFS on hardy at:

 chmod 755 bootcdmk2diskconf
./bootcdmk2diskconf -checktemplate
./bootcdmk2diskconf: 807: Syntax error: Missing '))'

[Nicolas Valcarcel (nvalcarcel)]

bootcdmk2diskconf is a bash script, and since "sh" points to "dash" it FTBFS i have just ping Bernd Schumacher and he tells he has always used bash, and he will fix it on the next release.

[Nicolas Valcarcel (nvalcarcel)]

Attaching patch which solves the FTBFS

[Luca Falavigna (dktrkranz)]

Thank you for your effort to fix this FTBFS.
Since your change is limited to bootcdmk2diskconf.src shebang (and just one line), applying it inline should be good enough.
Also, version should be 3.08ubuntu1.

Consider to report this to Debian Maintainer, so we can eventually sync bootcd in the future.

[Nicolas Valcarcel (nvalcarcel)]

I have discussed it with norsetto yesterday and we agreed that it's a better practice to use patch systems always.
I have already ping the debian maintainer and report the bug, he said that in debian isn't it because sh links to bash, but he will fix it on next release.

I'm attaching a new patch.

[Nicolas Valcarcel (nvalcarcel)]

Sorry about last debdiff, here is the correct one

[Cesare Tirabassi (norsetto)]

@luca: Please don't block uploads on the basis of using a patch system; I would block uploads quite for the contrary (note as well that this is a native package).

@nicolas: If bash is needed during build than the package should also build-depends on bash. Why do you add quilt as both build-depends and build-depends-indep? Check this for more details on build dependencies:

http://www.debian.org/doc/debian-policy/ch-relationships.html

I'm not particularly happy about making just one change to one script, they are all !/bin/sh scripts.
Can you check with the DD when he will upload a new package? If its not too late we could even wait and sync then.

[Nicolas Valcarcel (nvalcarcel)]

Ok i will ask the DM when he will also i will check the other sh scripts,
but i don't think they need to be changed because they work fine.
About adding bash as build dep i think i forget it :P
and thanks for the link, i was unsure about it so i added to the two of them
:P
Thanks for your time.

[Nicolas Valcarcel (nvalcarcel)]

Here is a new patch.

i've also report it to debian.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=453263

[Nicolas Valcarcel (nvalcarcel)]

The DM tell me he will release next version with the changes this year, and he can't be more exactly, also tell me there is no need to use bash, it only has a dash syntax error which y have fix and test in this new patch.

[Nicolas Valcarcel (nvalcarcel)]

sorry about last patch!

[Nicolas Valcarcel (nvalcarcel)]

Sorry once again

[Luke Yelavich (themuso)]

Uploaded, thanks for your work. Please ensure this gets synced from Debian as soon as this fix hits there.

[Nicolas Valcarcel (nvalcarcel)]

bootcd (3.08ubuntu1) hardy; urgency=low

  * Added 01bootcdmk2diskconf.src.diff patch:
    - Changes "((" with "( (" for dash compatibility (LP: #165030)
  * Implement quilt patch system:
    - Add quilt as a Build-Depends in debian/control
    - Add quilt support in debian/rules
  * debian/control: Update maintainer fields according to debian-
    maintainer-field spec.

 -- Nicolas Valcarcel Scerpella (aka nxvl) <email address hidden> Thu, 29 Nov 2007 11:44:40 -0500